Fix frames props view not updating on frame change #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2818451 updated the plugin to use a single `TableModel` instance, but changes to the underlying data are not emitted as signals, so the view doesn't update when the data changes. This patch fixes the issue by emitting the `layoutChanged` signal to trigger a redisplay. Didn't use `dataChanged` because it's possible that there are more or less rows (props) in the new table data, hence a layout change. Also didn't implement this in `TableModel` since the data mutation is happening directly in the plugin.
Setsugennoao
merged commit 72ed916
into
Jaded-Encoding-Thaumaturgy:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2818451 updated the plugin to use a single
TableModelinstance, but changes to the underlying data are not emitted as signals, so the view doesn't update when the data changes. This patch fixes the issue by emitting thelayoutChangedsignal to trigger a redisplay.Didn't use
dataChangedbecause it's possible that there are more or less rows (props) in the new table data, hence a layout change. Also didn't implement this inTableModelsince the data mutation is happening directly in the plugin.