Prevent triggering builds on closed PRs

Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci#54. Fixes: jenkinsci#865
JackPGreen · Aug 19, 2024 · bdc778e · bdc778e
1 parent ebd6df7
commit bdc778e
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/ghprb/GhprbRootAction.java b/src/main/java/org/jenkinsci/plugins/ghprb/GhprbRootAction.java
@@ -137,16 +137,14 @@ private void handleAction(String event,
         try {
             GitHub gh = GitHub.connectAnonymously();
 
-            if (StringUtils.equalsIgnoreCase("issue_comment", event)) {
+            if (state == GHIssueState.CLOSED) {
+                LOGGER.log(Level.INFO, "Skip ''{0}'' event on closed PR", event);
+                return;
+            } else if (StringUtils.equalsIgnoreCase("issue_comment", event)) {
 
                 comment = getIssueComment(payload, gh);
                 GHIssueState state = comment.getIssue().getState();
 
-                if (state == GHIssueState.CLOSED) {
-                    LOGGER.log(Level.INFO, "Skip comment on closed PR");
-                    return;
-                }
-
                 if (!comment.getIssue().isPullRequest()) {
                     LOGGER.log(Level.INFO, "Skip comment on Issue");
                     return;