Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of blank slate from Jim #2

Merged
merged 1 commit into from
Jun 13, 2014

Conversation

pboling
Copy link
Collaborator

@pboling pboling commented Jun 6, 2014

JackDanger added a commit that referenced this pull request Jun 13, 2014
Latest version of blank slate from Jim
@JackDanger JackDanger merged commit 9f0a2f8 into JackDanger:master Jun 13, 2014
@JackDanger
Copy link
Owner

Thank you for this, @pboling. It sorta surprised me, then saddened me, and then delighted me to see this in my inbox.

@pboling
Copy link
Collaborator Author

pboling commented Jun 16, 2014

@JackDanger I think this will resolve the warnings people (including me) are complaining endlessly about here and here.

Can it go to rubygems.org as a patch release?

My only concern is this includes a bit more than had previously been defined in 'blankslate'. It provides _blankslate_as_name if not defined on String and Symbol classes. But I think probably not too big a deal as code will be moving to BasicObject form Ruby 2 forward...

@pboling pboling deleted the patch-1 branch June 16, 2014 23:24
@JackDanger
Copy link
Owner

I've pushed a new version (2.1.3) with these changes. And I took the time to add a Gemfile (finally).

@pboling
Copy link
Collaborator Author

pboling commented Jun 18, 2014

I am confused now on several levels.

We were on version 3.1.2 of the gem, which was released Sep 7, 2012.

You have now released 2.1.3, which I can see on Rubygems.org as the most recently released, but it is not the 'toppermost' version, since 2.1.3 < 3.1.2.

But the VERSION file, which the gemspec reads to get the version, still says '2.1.2.4', and hasn't been touched since 2011.

@JackDanger Wat? I feel I lack some context here. :)

@pboling
Copy link
Collaborator Author

pboling commented Jun 18, 2014

FWIW the dependency I have that is pulling in this gem is jimson-temp (v0.9.5). It in turn is pulled in by stripe-ruby-mock (v1.10.1.7).

The jimson-temp dependency is as follows:

    jimson-temp (0.9.5)
      blankslate (>= 3.1.2)

So, it will not let me use your just released fix. :(

@JackDanger
Copy link
Owner

@pboling This is a bit strange. It looks like the 3.x gem that snuck in there was a package of builder v 3. To fix this I've bumped blankslate's version to 3.1.3 and pushed it. Your problems should be solved!

@pboling
Copy link
Collaborator Author

pboling commented Jun 18, 2014

Wow that's strange. So you're telling me jimson-temp may be depending in reality on builder, not blankslate at all (though the class Blankslate is provided by builder)?

I need to dig into this more. Thanks for checking.

@pboling
Copy link
Collaborator Author

pboling commented Jun 18, 2014

@JackDanger I downloaded the 3.1.2 thing. It is a hackmash of builder. A very poorly packaged bundler pared down to just including the blankslate file. It was not done at all carefully, and left in the tests for the rest of builder and many references to builder source that is missing (in the Rakefile, for example). So... Kind of a shit basket of a gem.

Functionally it looks like there would be no runtime compatibility issues, so I think your latest release is all good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants