-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix container builds, merge/rename spack-stack extension repos, add Intel oneAPI 2024.0.2 compiler/MPI on AWS ParallelCluster #966
Fix container builds, merge/rename spack-stack extension repos, add Intel oneAPI 2024.0.2 compiler/MPI on AWS ParallelCluster #966
Conversation
…r environment directory / yaml
…tainers/docker-ubuntu-clang-mpich.yaml
… into spack-ext/repos/spack-stack
…ainers/docker-ubuntu-clang-mpich.yaml, configs/containers/docker-ubuntu-gcc-openmpi.yaml and setup.sh with name of new spack-stack extension repo
@@ -1,15 +1,3 @@ | |||
# Use '-i' when sourcing this file to attempt to reset $PATH to system defaults (i.e., based on /etc/profile), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't used this and I don't think we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I can go either way. I'm okay with removing it for now, but if we run into issues again like we had with the ESMF recipe where it was using the calling environment (incl. PATH) rather than the Spack build environment in places, then we should revisit and try to make it work on all systems (I don't remember how far I got with testing, I think it worked on more than just Acorn and Orion but those were the ones that needed added customization).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks. I'll take it out for now. I never had to do anything particular about the environment except for Cray systems where you need to have a separate set of modules loaded, depending on the compiler you build for (see Narwhal instructions). Since we've agreed today to move forward with separate environments for different compilers, that will be even less of an issue (again, essentially doing what we already do for Narwhal).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (apart from .gitmodules)
Summary
Several changes to fix the broken container builds and reorganize our repos:
pflogger
updates (to fix broken clang/mpich container builds of pflogger)spack-ext/repos
: combinejcsda-emc
andjcsda-emc-bundles
intospack-stack
(we also have EPIC and may have more partners in the future, so this makes a lot of sense)setup.sh
(so that docker can recognize updates and doesn't use the cache if spack-stack has changed) and physically copying the repos directory into the container environment directory (because the docker build runs from that directory and everything above is not in its context)Unrelated, and commented out by default:
aws-pcluster
site for testingTesting
jedi-intel-impi- will be run laterApplications affected
n/a
Systems affected
spack-stack containers
Dependencies
Issue(s) addressed
Resolves #965
Resolves #960
Checklist