Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule pointer for spack for umask check when creating envs #657

Merged
merged 8 commits into from
Jul 3, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 30, 2023

Summary

This PR only updates the submodule pointer for spack for checking the user's umask check when creating environments.

Testing

  • Tested manually on macOS setting a bunch of umask values
  • Tested manually on the Navy's Nautilus system, which has a "bad" default umask (0x077)
  • CI testing - check log output manually to make sure the check umask output is there

Applications affected

n/a - it only issues a warning written to stdout, nothing else is done.

Systems affected

n/a

Dependencies

Issue(s) addressed

See JCSDA/spack#289

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Jun 30, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jun 30, 2023
@climbfuji climbfuji marked this pull request as ready for review June 30, 2023 14:14
@climbfuji
Copy link
Collaborator Author

@ulmononian @AlexanderRichert-NOAA These umask check PRs (here, and in spack) are ready.

Copy link
Collaborator

@ulmononian ulmononian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛤️🪐

@climbfuji climbfuji merged commit 862f63e into JCSDA:develop Jul 3, 2023
@climbfuji climbfuji deleted the feature/check_user_umask branch July 3, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants