-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add util for checking installation permissions #652
Add util for checking installation permissions #652
Conversation
@climbfuji let me know what you think-- I don't know if the script is portable for Macs since I can't test, but I also don't know that there will ever be a situation where a Mac user needs to worry about permissions for other users. |
This is a neat utility, however I think what would be even better (or a good additional step) is a simple check in |
That sounds good-- I can think of some cases that would make it worth doing both (weird build systems; network FS quirks on Acorn). The one limitation I can think of is that creating and installing the environment could theoretically be done at two different times with different umasks... but short of creating our own install command, it couldn't hurt to have |
I can take care of that part, thanks for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add this step to the CI? We know that there should be no wrong permissions, but it would be good to run the script nonetheless?
Generally I think using this command will lead us to run chmod on our installations, as opposed to leading to "deep" changes to configs/recipes/codes. So for now I would say we don't need it in the CI, but we should revisit it if we run into issues that need a solution beyond just running chmod. |
I would like to see the script being exercise = tested to not blow up, that's why I was asking. But it's ok as it is, too. |
Ah I see what you mean. I think in a separate PR I'll add CI testing for utilities (including testing various cases for the duplicate checker). |
Summary
This PR adds a utility (with doco) for checking the permissions of installations, specifically to ensure that non-owning users/groups can access them.
Testing
Tested the functionality/logic of the utility in CentOS 8 with some dummy files.
Applications affected
No impact.
Systems affected
No impact (except for helping identify permissions problems).
Dependencies
n/a
Issue(s) addressed
n/a
Checklist