release/1.8.0: bug fix for compiling [email protected] with gfortran < 10 in spack package, remove from container configs #1287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For release/1.8.0: Update submodule pointer for spack for the changes in JCSDA/spack#477. Remove
g2
compiler flags in container configs, since these are now in theg2
package itself.Also include a bug fix to adjust the py-numpy version to match what is in configs/common/packages.yaml since yesterday (1.23.5).
Note that the gettext and grib-util updates in JCSDA/spack#477 are not part of this PR. They were tested earlier and merged into spack release/1.8.0, but the submodule pointer in spack-stack release/1.8.0 wasn't updated after that.
Testing
Ignore any Github actions CI errors reported below. They are not meaningful for PRs going into release/1.8.0 (I tried to run them but messed up something).
"Manual" CI testing via
workflow_dispatch
is recorded below shows that the clang-mpich container builds successfully (which requires the g2 flags), but then the CI run screwed up because of my manual modifications to the Github actions workflow (that I have since reverted): https://github.com/JCSDA/spack-stack/actions/runs/10724678450/job/29740852419.Therefore, this is good to merge.
Applications affected
UFS / JEDI+UFS
Systems affected
All using gfortran < 10
Dependencies
Issue(s) addressed
Resolves JCSDA/spack#475
Checklist