Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.8.0: bug fix for compiling [email protected] with gfortran < 10 in spack package, remove from container configs #1287

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 5, 2024

Summary

For release/1.8.0: Update submodule pointer for spack for the changes in JCSDA/spack#477. Remove g2 compiler flags in container configs, since these are now in the g2 package itself.

Also include a bug fix to adjust the py-numpy version to match what is in configs/common/packages.yaml since yesterday (1.23.5).

Note that the gettext and grib-util updates in JCSDA/spack#477 are not part of this PR. They were tested earlier and merged into spack release/1.8.0, but the submodule pointer in spack-stack release/1.8.0 wasn't updated after that.

Testing

Ignore any Github actions CI errors reported below. They are not meaningful for PRs going into release/1.8.0 (I tried to run them but messed up something).

"Manual" CI testing via workflow_dispatch is recorded below shows that the clang-mpich container builds successfully (which requires the g2 flags), but then the CI run screwed up because of my manual modifications to the Github actions workflow (that I have since reverted): https://github.com/JCSDA/spack-stack/actions/runs/10724678450/job/29740852419.

Therefore, this is good to merge.

Applications affected

UFS / JEDI+UFS

Systems affected

All using gfortran < 10

Dependencies

Issue(s) addressed

Resolves JCSDA/spack#475

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji changed the base branch from develop to release/1.8.0 September 5, 2024 15:18
@climbfuji climbfuji self-assigned this Sep 5, 2024
@climbfuji climbfuji changed the title WIP - Bugfix/g2 gnu fix release/1.8.0: bug fix for compiling [email protected] with gfortran < 10 in spack package, remove from container configs Sep 5, 2024
@climbfuji climbfuji enabled auto-merge (squash) September 5, 2024 21:40
@climbfuji climbfuji merged commit bd00b5e into JCSDA:release/1.8.0 Sep 5, 2024
8 checks passed
@climbfuji climbfuji deleted the bugfix/g2-GNU-fix branch September 6, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants