Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge spack develop as of 2024/05/09 into spack-stack-dev #1109

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented May 10, 2024

Summary

This PR updates our spack branch to spack develop as of 2024/05/09 (spack 0.22.0.dev0 (4154b2d83f87ae1408ceb604d6b9d5fee444f866)). See JCSDA/spack#432 for details.

This update requires a few bug fixes in our common and site configs, part of this PR.

Testing

Describe the testing done for this PR.

Applications affected

All

Systems affected

All

Dependencies

Issue(s) addressed

n/a

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

…ing' can now be False instead of an empty dictionary
…ges.yaml with new versions and bug fixes for unified-env build
…eature/merge_spack_develop_into_spack_stack_dev_20240509
@climbfuji climbfuji force-pushed the feature/merge_spack_develop_into_spack_stack_dev_20240509 branch from d8116e6 to ba3ffb1 Compare May 13, 2024 16:53
@climbfuji climbfuji self-assigned this May 14, 2024
@climbfuji climbfuji added NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center NAVY United States Naval Research Lab labels May 14, 2024
@climbfuji climbfuji marked this pull request as ready for review May 15, 2024 11:26
@@ -7,6 +7,8 @@
fftw-api: [fftw]
gl: [opengl]
glu: [openglu]
# DH* CHECK IF NEEDED
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self. Remove

@@ -5,5 +5,8 @@ packages:
buildable: false
libiconv:
buildable: false
# DH* CHECK IF NEEDED
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self - check

@AlexanderRichert-NOAA
Copy link
Collaborator

FWIW I'm getting a bunch of the following when concretizing on Hera:

==> Warning: cannot detect libc from intel@=18.0.5.274. The compiler will not be used during concretization.
==> Warning: cannot detect libc from gcc@=4.4.7. The compiler will not be used during concretization.

Can we remove those compilers anyway (not in this PR, but before the next release)?

@climbfuji
Copy link
Collaborator Author

FWIW I'm getting a bunch of the following when concretizing on Hera:

==> Warning: cannot detect libc from intel@=18.0.5.274. The compiler will not be used during concretization.
==> Warning: cannot detect libc from gcc@=4.4.7. The compiler will not be used during concretization.

Can we remove those compilers anyway (not in this PR, but before the next release)?

Absolutely! A site config cleanup before the 1.8.0 release would be a good thing,

@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA Let's incorporate any site specific changes in this PR. Regarding netcdf-cxx4, please see the link above to the issue I created. We should consider reverting to the old and proven autotools build in our fork until that is resolved.

@AlexanderRichert-NOAA
Copy link
Collaborator

I'm fine with that re: netcdf-cxx4. Do you want to go ahead and revert the recipe in the spack PR if you haven't already?
I'll update the Hera config momentarily...

@climbfuji
Copy link
Collaborator Author

I'm fine with that re: netcdf-cxx4. Do you want to go ahead and revert the recipe in the spack PR if you haven't already? I'll update the Hera config momentarily...

I reverted netcdf-cxx4 back to the version we had before the update

…eature/merge_spack_develop_into_spack_stack_dev_20240509
@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA @RatkoVasic-NOAA I would like to merge this PR this week if possible before I go on leave next week. Do you think that is feasible? It built straight out of the box on Nautilus with [email protected] after the netcdf-cxx4 build tool reversal.

@AlexanderRichert-NOAA
Copy link
Collaborator

Yes. Do you want to merge climbfuji#7? I'll go ahead and approve since everything else looks good to me.

@climbfuji
Copy link
Collaborator Author

Yes. Do you want to merge climbfuji#7? I'll go ahead and approve since everything else looks good to me.

Yes, thanks very much!

@climbfuji climbfuji merged commit 296cd59 into JCSDA:develop May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NAVY United States Naval Research Lab NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center
Projects
Development

Successfully merging this pull request may close these issues.

2 participants