Update develop from release/1.7.0 and rename spack fork branch #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpich.yaml, configs/containers/docker-ubuntu-gcc-openmpi.yaml, configs/containers/docker-ubuntu-intel-impi.yaml, doc/source/conf.py: replace jcsda_emc_spack_stack branch name with release/1.7.0
…in modules for backward compatibility; update authorlist in doc conf (JCSDA#1037) * Update authorlist in doc/source/conf.py * Provide lowercase env variables jedi_cmake_ROOT and atlas_ROOT for backward compatibility in spack-stack-1.7.0 only
…SDA#1040) * Disable xnnpack variant for py-torch on discover-scu16 * Update project_charter.md with new environment names * Fix bad indentation in configs/sites/derecho/compilers.yaml
…date hera update for 1.7.0
…ule_170 grib-util module fix
….7.0 Jet update 1.7.0
* Bug fix in configs/sites/discover-scu17/compilers.yaml: remove duplicate env variable * Documentation updates for release-1.7.0 * Update discover-scu16 intel config and documentation, and add note in doc/source/NewSiteConfigs.rst about problems of [email protected] with zlib-ng * Update documentation for S4 and for problems of zlib-ng with [email protected] on some systems * Update documentation for new Redhat 8 site configs * Switch to tag spack-stack-1.7.0 for spack submodule * Update doc/source/PreConfiguredSites.rst with information on mapl version/variant differences
…env variables for backward compatibility
…_root release/1.7.0: revert uppercase PACKAGE_ROOT env vars
… release changes in configs/containers/*.yaml and doc/source/conf.py
climbfuji
commented
Apr 11, 2024
| @@ -1,9 +1,7 @@ | |||
| [submodule "spack"] | |||
| path = spack | |||
| #url = https://github.com/spack/spack | |||
There was a problem hiding this comment.
Time to let go ...
…_lmod.yaml and configs/common/modules_tcl.yaml
climbfuji
added
INFRA
climbfuji
requested review from
AlexanderRichert-NOAA,
srherbener,
RatkoVasic-NOAA and
natalie-perlin
AlexanderRichert-NOAA
approved these changes
Apr 11, 2024
srherbener
approved these changes
Apr 11, 2024
climbfuji
commented
Apr 11, 2024
| modules: | ||
| - gnu/9.2.0 | ||
| - openmpi/4.1.5 | ||
| - openmpi/4.1.6_gnu9.2.0 |
There was a problem hiding this comment.
Maybe we should try making this the default for all builds (especially Intel) to avoid the issues we've seen with [email protected]? Not sure. Worth discussing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update develop from release/1.7.0. I reverted the usual changes to the container configs (yamls),
.gitconfiganddoc/src/conf.pyas for every other release.On top of that, this PR contains the necessary changes following the renaming of the spack fork branch (and default branch in https://github.com/JCSDA/spack), which affect the container configs (yamls) and
.gitmodules.See announcement #1073 for more information on the branch renaming.
Testing
The release branch was tested heavily on all systems and in CI. This PR is tested in CI (see below)
Applications affected
All (but see testing)
Systems affected
All (but see testing)
Dependencies
Issue(s) addressed
Link the issues addressed or resolved by this PR (use
Fixes #???for fully resolved issues)Checklist