-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/1.7.0: revert uppercase PACKAGE_ROOT env vars #1068
release/1.7.0: revert uppercase PACKAGE_ROOT env vars #1068
Conversation
…env variables for backward compatibility
It sounds like it should work to run |
Please try, yes. I'll do the following after this is merged and spack-stack tagged (so that I know for sure I have the final tag on the system):
|
@AlexanderRichert-NOAA I think we can merge this first, then tag and complete the list above. I tested it on my macOS and it works as expected. |
@climbfuji - |
... appears to be... |
Sorry, not being sufficiently clear - I mean that we run full sequence of commands, except there is no "origin/1.7.0" branch, and it's "release/1.7.0" |
|
I've done my share except Derecho and Casper, which are currently offline due to network issues. I'll check back tonight and complete my assignments |
@natalie-perlin yes, the environment needs to be activated so Spack knows which environment to do the module updates for. |
... done with NOAA Parallel Works CSP |
Thank you @natalie-perlin ! |
@AlexanderRichert-NOAA Only Acorn missing I think |
Summary
Update submodule pointer for the changes described in JCSDA/spack#421 and remove the previously added
jedi_cmake_ROOT env vars in configs/common/modules_*.yaml
.This is for the release branch. After this is merged, we will need to retag the spack submodule, update spack-stack (remove the extra JEDI_CMAKE_ROOT env settings in
configs/common/modules.*yaml
), tag, go back to all supported platforms, check out the final tagged code, and rerun thespack module ??? refresh && spack stack setup-meta-modules
commands.List of platforms:
AWS ParallelCluster(decommissioned - if resurrected, then @climbfuji)Testing
Applications affected
All = none (because our applications still expect the lowercase/case-preserving version)
Systems affected
All
Dependencies
Issue(s) addressed
Resolves #1066
Checklist