Isset purchase update fix #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprew97
requested changes
Jul 9, 2024
| Object.keys(item).includes(searchQuery.field) | ||
| ); | ||
| const filteredSearchQueries = []; | ||
| for (let i = 0; i < searchQueries.length; i++) { |
There was a problem hiding this comment.
I know we need to add some lint rules to prevent some of these back and forths we have on PRs, but please use array methods over for loops when possible.
| @@ -439,6 +470,16 @@ class CriteriaCompletionChecker { | |||
| } | |||
| } | |||
|
|
|||
| private issetCheck(matchObj: any): boolean { | |||
There was a problem hiding this comment.
If this is a json obj,
Suggested change
| private issetCheck(matchObj: any): boolean { | |
| private issetCheck(matchObj: Record<any,any>): boolean { |
There was a problem hiding this comment.
then what is it? would prefer to be explicit here
There was a problem hiding this comment.
please properly type this. after that is done, can merge.
|
matchObj can be anything (string, boolean, double, integer)
…On Wed, Jul 10, 2024 at 7:41 PM Mitch Prewitt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/anonymousUserTracking/criteriaCompletionChecker.ts
<#416 (comment)>
:
> @@ -439,6 +470,16 @@ class CriteriaCompletionChecker {
}
}
+ private issetCheck(matchObj: any): boolean {
then what is it? would prefer to be explicit here
—
Reply to this email directly, view it on GitHub
<#416 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDZHOGNJ6IUOSMDKZNYPNGLZLU6JBAVCNFSM6AAAAABKMTS6PSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRZGI2TSMJQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mprew97
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description