properly format query params for get requests

Iterable · Jul 11, 2024 · d33a66f · d33a66f
1 parent 5572d30
commit d33a66f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/src/embedded/embeddedManager.ts b/src/embedded/embeddedManager.ts
@@ -33,21 +33,11 @@ export class IterableEmbeddedManager {
     placementIds: number[]
   ) {
     try {
-      const params: any = {};
-      if (placementIds.length > 0) {
-        params.placementIds = placementIds[0];
-        if (placementIds.length > 1) {
-          params.placementIds += placementIds
-            .slice(1)
-            .map((id) => `&placementIds=${id}`)
-            .join('');
-        }
-      }
       const iterableResult: any = await baseIterableRequest<IterableResponse>({
         method: 'GET',
         url: ENDPOINTS.get_embedded_messages.route,
         params: {
-          ...params,
+          placementIds,
           platform: WEB_PLATFORM,
           sdkVersion: SDK_VERSION,
           packageName: packageName

diff --git a/src/request.ts b/src/request.ts
@@ -1,4 +1,5 @@
 import Axios, { AxiosRequestConfig } from 'axios';
+import qs from 'qs';
 import { BASE_URL, STATIC_HEADERS, EU_ITERABLE_API } from './constants';
 import { IterablePromise, IterableResponse } from './types';
 import { AnySchema, ValidationError } from 'yup';
@@ -46,6 +47,9 @@ export const baseIterableRequest = <T = any>(
       headers: {
         ...payload.headers,
         ...STATIC_HEADERS
+      },
+      paramsSerializer: (params) => {
+        return qs.stringify(params, { arrayFormat: 'repeat' });
       }
     });
   } catch (error) {