Fixed bools needs to be string (#422)

Iterable · Jul 31, 2024 · 7c04dba · 7c04dba
1 parent 06c55d9
commit 7c04dba
Show file tree

Hide file tree

Showing 3 changed files with 78 additions and 4 deletions.
diff --git a/react-example/src/views/AUTTesting.tsx b/react-example/src/views/AUTTesting.tsx
@@ -40,7 +40,7 @@ export const AUTTesting: FC<Props> = () => {
   const [isUpdatingCart, setUpdatingCart] = useState<boolean>(false);
   const [isTrackingPurchase, setTrackingPurchase] = useState<boolean>(false);
   const [userDataField, setUserDataField] = useState<string>(
-    ' { "dataFields": {"phone_number": "57688559" }}'
+    ' { "dataFields": {"phone_number": "57688559", "subscribed": true }}'
   );
   const [isUpdatingUser, setUpdatingUser] = useState<boolean>(false);
   const [updateUserResponse, setUpdateUserResponse] = useState<string>(

diff --git a/src/anonymousUserTracking/criteriaCompletionChecker.ts b/src/anonymousUserTracking/criteriaCompletionChecker.ts
@@ -412,13 +412,14 @@ class CriteriaCompletionChecker {
   private compareValueEquality(sourceTo: any, stringValue: string): boolean {
     if (
       (typeof sourceTo === 'number' || typeof sourceTo === 'boolean') &&
-      stringValue !== '' &&
-      !isNaN(parseFloat(stringValue))
+      stringValue !== ''
     ) {
-      if (typeof sourceTo === 'number') {
+      if (typeof sourceTo === 'number' && !isNaN(parseFloat(stringValue))) {
         return sourceTo === parseFloat(stringValue);
       } else if (typeof sourceTo === 'boolean') {
         return sourceTo === (stringValue === 'true');
+      } else {
+        return false;
       }
     } else if (typeof sourceTo === 'string') {
       return sourceTo === stringValue;

diff --git a/src/anonymousUserTracking/tests/criteriaCompletionChecker.test.ts b/src/anonymousUserTracking/tests/criteriaCompletionChecker.test.ts
@@ -1445,4 +1445,77 @@ describe('CriteriaCompletionChecker', () => {
     );
     expect(result).toEqual(null);
   });
+
+  it('should return criteriaId 100 (boolean test)', () => {
+    (localStorage.getItem as jest.Mock).mockImplementation((key) => {
+      if (key === SHARED_PREFS_EVENT_LIST_KEY) {
+        return JSON.stringify([
+          {
+            dataFields: {
+              subscribed: true,
+              phoneNumber: '99999999'
+            },
+            eventType: 'user'
+          }
+        ]);
+      }
+      return null;
+    });
+
+    const localStoredEventList = localStorage.getItem(
+      SHARED_PREFS_EVENT_LIST_KEY
+    );
+
+    const checker = new CriteriaCompletionChecker(
+      localStoredEventList === null ? '' : localStoredEventList
+    );
+    const result = checker.getMatchedCriteria(
+      JSON.stringify({
+        count: 1,
+        criterias: [
+          {
+            criteriaId: '100',
+            name: 'User',
+            createdAt: 1716560453973,
+            updatedAt: 1716560453973,
+            searchQuery: {
+              combinator: 'And',
+              searchQueries: [
+                {
+                  combinator: 'And',
+                  searchQueries: [
+                    {
+                      dataType: 'user',
+                      searchCombo: {
+                        combinator: 'And',
+                        searchQueries: [
+                          {
+                            field: 'subscribed',
+                            fieldType: 'boolean',
+                            comparatorType: 'Equals',
+                            dataType: 'user',
+                            id: 25,
+                            value: 'true'
+                          },
+                          {
+                            field: 'phoneNumber',
+                            fieldType: 'String',
+                            comparatorType: 'IsSet',
+                            dataType: 'user',
+                            id: 28,
+                            value: ''
+                          }
+                        ]
+                      }
+                    }
+                  ]
+                }
+              ]
+            }
+          }
+        ]
+      })
+    );
+    expect(result).toEqual('100');
+  });
 });