Fix recursion test case for Python 3.12 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vtermanis
commented
Oct 20, 2023
•
vtermanis
commented
- To address Test failures with Python 3.12 #18
- Update pylint.rc or 3.0.1 - Minor code changes for warnings
|
Hi, is there anything to do before merging this? Maybe I can help |
|
This PR doesn't really fix tests for latest version of python 3.12. The simplest way to fix the tests is to not call /setrecursionlimit/, just getrecursionlimit. |
It's not that - there's a good reason why the tests set the limit previously: The test would otherwise take too long to generate the required data or fail with a different error on earlier versions (I believe < 3.4 & 2.7.) I'm planning to drop support for everything < 3.8 and then indeed no setting should be needed, it appears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.