Actions and Doctrine to Schema Changes #4
Conversation
There was a problem hiding this comment.
Thank you a lot, @gangaiamaran for your contribution!
We planned to update this code to support Laravel 11, but you did it! I feel the power of the community! 💪 Great job on this PR. I left some notes for minor changes, please take a look.
Thank you!
| @@ -218,4 +210,15 @@ private function formatBytes(int $size, int $precision): string | |||
| $suffix = $suffixes[$index]; | |||
| return round(1024 ** ($base - floor($base)), $precision).$suffix; | |||
| } | |||
| protected function getTableSize($connection, string $table) | |||
There was a problem hiding this comment.
this is a final class, there is not a lot of sense in making this method protected. How about making it private? (and adding a return and param types)
There was a problem hiding this comment.
I agree. It would make more sense to change the method to private. I'll also add the return and parameter types as you suggested.
Thanks for the catch!
We can use Schema size instead of getTableSize()
| @@ -17,4 +24,13 @@ protected function getPackageProviders($app): array | |||
| DatabaseToolkitServiceProvider::class, | |||
| ]; | |||
| } | |||
|
|
|||
| protected function tearDown(): void | |||
There was a problem hiding this comment.
I like the idea! But I'm not sure we need this in the base TestCase class, because some tests (e.g. unit) may not need DB at all.
There was a problem hiding this comment.
You're right, it's not necessary in the base TestCase class. I'll consider adding it only where needed.
This PR contains the following updates:
Configured MySQL Service in GitHub Actions:
Added Laravel 11 Actions Test Run Support:
Enhanced Test Coverage:
tinyint) within theFindRiskyDatabaseColumnscommand to improve overall test coverage.Next Steps
FindInvalidDatabaseValuesAction URL
