fix: NRE in codegen for models with instance methods that lack a PK

IntelliTect · Sep 23, 2024 · a86b432 · a86b432
1 parent 52f8341
commit a86b432
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/IntelliTect.Coalesce/TypeDefinition/MethodViewModel.cs b/src/IntelliTect.Coalesce/TypeDefinition/MethodViewModel.cs
@@ -177,15 +177,15 @@ public IEnumerable<ParameterViewModel> ApiParameters
             get
             {
                 var parameters = ClientParameters;
-                if (IsModelInstanceMethod)
+                if (IsModelInstanceMethod && Parent.PrimaryKey != null)
                 {
                     parameters = new[]
                     {
                         new ImplicitParameterViewModel(
                             this,
-                            Parent.PrimaryKey!,
+                            Parent.PrimaryKey,
                             "id", 
-                            "Primary Key" // TODO: Is this what we want? Also, i18n.
+                            "Primary Key"
                         )
                     }.Concat(parameters);
                 }

diff --git a/src/IntelliTect.Coalesce/Validation/ValidateContext.cs b/src/IntelliTect.Coalesce/Validation/ValidateContext.cs
@@ -123,7 +123,6 @@ public static ValidationHelper Validate(ReflectionRepository repository)
                         if (prop.ReferenceNavigationProperty is not null)
                         {
                             assert.IsNotNull(prop.ReferenceNavigationProperty.Object, "Object property related object not found.");
-                            assert.IsNotNull(prop.ReferenceNavigationProperty.Object?.PrimaryKey, "No primary key on type of this ID's Navigation Property.");
                         }
 
                         if (prop.Type.IsCollection)