fix(audit): improper default formatting for primitive collections. (#459

)

CHANGELOG.md

@@ -4,6 +4,7 @@
 - feat(template): Added multi-tenancy options to the template. (#441, #461)
 - fix(template): adjust manual chunking configuration to avoid circular deps. (#455)
 - fix(audit): key props now respect configured property exclusions.
+- fix(audit): improper default formatting for primitive collections. (#459)
 - fix: c-admin-method now preserves newlines when displaying success messages.
 - fix: c-select not defaulting optional method parameters as clearable.
 - fix: method object parameters passed sent as null on the client are received as a default instance of the object on the server. (#456)

src/IntelliTect.Coalesce.AuditLogging.Tests/AuditTests.cs

@@ -1,3 +1,4 @@
+using IntelliTect.Coalesce.DataAnnotations;
 using IntelliTect.Coalesce.Utilities;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
@@ -406,6 +407,22 @@ public async Task PropertyDesc_OnlyLoadsPrincipalWhenChanged()
         Assert.Null(user.Parent1);
     }
 
+    [Fact]
+    public void FormatsPrimitiveCollections()
+    {
+        using var db = BuildDbContext(b => b
+            .UseCoalesceAuditLogging<TestAuditLog>(x => x
+                .WithAugmentation<TestOperationContext>()
+            ));
+
+        db.Add(new AppUser { Name = "Bob", EnumArray = [SecurityPermissionLevels.DenyAll, SecurityPermissionLevels.AllowAuthenticated] });
+        db.SaveChanges();
+
+        var log = Assert.Single(db.AuditLogs);
+        var prop = Assert.Single(log.Properties!.Where(p => p.PropertyName == nameof(AppUser.EnumArray)));
+        Assert.Equal("[DenyAll, AllowAuthenticated]", prop.NewValue);
+    }
+
     private WebApplicationBuilder CreateAppBuilder()
     {
         var builder = WebApplication.CreateBuilder();

src/IntelliTect.Coalesce.AuditLogging.Tests/TestDbContext.cs

@@ -34,6 +34,8 @@ class AppUser
     public DateTimeOffset? NullableValueType { get; set; }
 
     public bool BoolProp { get; set; }
+
+    public SecurityPermissionLevels[]? EnumArray { get; set; }
 }
 
 class ParentWithMappedListText

src/IntelliTect.Coalesce.AuditLogging/Models/AuditConfiguration.cs

@@ -121,6 +121,11 @@ public AuditConfiguration FormatType<T>(Func<T, string?> formatter)
                 return formatter(currentValue);
             }
         }
+
+        if (currentValue is System.Collections.ICollection collection)
+        {
+            return $"[{string.Join(", ", collection.OfType<object>())}]";
+        }
 
         return currentValue.ToString();
     }