Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses issues related to maven publish scm block #309

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Addresses issues related to maven publish scm block #309

merged 2 commits into from
Oct 1, 2023

Conversation

BlockyTheDev
Copy link
Contributor

Overview

Fixes #296
Fixes #297
Resolves #295

Description

Addresses issues related to maven publish scm block

Submitter Checklist
Beta Give feedback

@BlockyTheDev BlockyTheDev requested a review from a team as a code owner October 1, 2023 00:31
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 1, 2023
NotMyFault
NotMyFault requested changes Oct 1, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#297 has not yet been addressed

@BlockyTheDev
Copy link
Contributor Author

#297 has not yet been addressed

But now, it is 😄

@NotMyFault NotMyFault merged commit 79ba558 into IntellectualSites:main Oct 1, 2023
5 checks passed
@BlockyTheDev BlockyTheDev deleted the fix/main/maven-publish-scm branch October 1, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update wrong SCM URL Update wrong developerConnection URL Add the tag to the generated pom
2 participants
@BlockyTheDev @NotMyFault