Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace plugins versions withe commit hash #3212

Merged
merged 3 commits into from
Sep 26, 2024
Merged

replace plugins versions withe commit hash #3212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9626df
replace plugins versions withe commit hash
Noy-Zini Sep 24, 2024
3151f4e
Replace reference to master with latest commit hash
Noy-Zini Sep 24, 2024
63a303d
adjustments
Noy-Zini Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
run: |
mkdir -p ${{github.workspace}}/ros2/src

- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 #v4
with:
path: 'ros2/src/realsense-ros'

Expand All @@ -61,17 +61,17 @@ jobs:
# so, seperating steps with if conditions
- name: build ROS2 for foxy
if: ${{ matrix.ros_distro == 'foxy' }}
uses: ros-tooling/[email protected]
uses: ros-tooling/setup-ros@0395475ab6416edc274bb3c43673b2091a217e02 #v0.6
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since I saw failures in the FOXY distro, I think this hash is the reasons.
I think it should be replaced with this hash:
236ab287884fd5a314fc030e91b2017abb46719e
See: https://github.com/ros-tooling/setup-ros/commits/v0.6/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to 236ab287884fd5a314fc030e91b2017abb46719e (v0.6 0.6.3)

with:
required-ros-distributions: ${{ matrix.ros_distro }}
- name: build ROS2 for humble/iron/rolling/jazzy
if: ${{ matrix.ros_distro != 'foxy' }}
uses: ros-tooling/[email protected]
uses: ros-tooling/setup-ros@a6ce30ecca1e5dcc10ae5e6a44fe2169115bf852 #v0.7
with:
required-ros-distributions: ${{ matrix.ros_distro }}

- name: Checkout librealsense/development
uses: actions/checkout@v4
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 #v4
with:
repository: IntelRealSense/librealsense
path: librealsense
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ jobs:
BASEDIR: ${{ github.workspace }}/.work

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 #v4
- name: industrial_ci
uses: ros-industrial/industrial_ci@master
Nir-Az marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion .github/workflows/static_analysis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
name: cppcheck
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 #v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use checkout v4 here with the hash: 692973e3d937129bcbf40652eb9f2f61becf3332
as we are already using v4 in other files..


- name: Install
shell: bash
Expand Down
Loading