Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch workflows to not use intel channel. #1483

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

diptorupd
Copy link
Collaborator

@diptorupd diptorupd commented Jul 20, 2024

Fixes #1481

Copy link
Contributor

Documentation preview: show.

@coveralls
Copy link
Collaborator

coveralls commented Jul 20, 2024

Coverage Status

coverage: 86.537% (+0.06%) from 86.48%
when pulling 623a204 on fix/github-workflows
into e80fdd0 on main.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a once over. All changes look good. Thanks @diptorupd !

@@ -170,7 +170,7 @@ jobs:
# We want to make sure that all dependecies install automatically.
# intel::intel-opencl-rt is needed for set-intel-ocl-icd-registry.ps1
- name: Install built package
run: conda install ${{ env.PACKAGE_NAME }}=${{ env.PACKAGE_VERSION }} intel::intel-opencl-rt -c ${{ env.CHANNEL_PATH }}
run: conda install ${{ env.PACKAGE_NAME }}=${{ env.PACKAGE_VERSION }} https://software.repos.intel.com/python/conda::intel-opencl-rt -c ${{ env.CHANNEL_PATH }} --override-channels
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: conda install ${{ env.PACKAGE_NAME }}=${{ env.PACKAGE_VERSION }} https://software.repos.intel.com/python/conda::intel-opencl-rt -c ${{ env.CHANNEL_PATH }} --override-channels
run: conda install ${{ env.PACKAGE_NAME }}=${{ env.PACKAGE_VERSION }} 'https://software.repos.intel.com/python/conda::intel-opencl-rt' -c ${{ env.CHANNEL_PATH }}

Try this. I guess bash may split arguments...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it did not work

Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa Jul 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: conda install ${{ env.PACKAGE_NAME }}=${{ env.PACKAGE_VERSION }} https://software.repos.intel.com/python/conda::intel-opencl-rt -c ${{ env.CHANNEL_PATH }} --override-channels
run: conda install ${{ env.PACKAGE_NAME }}=${{ env.PACKAGE_VERSION }} intel-opencl-rt -c ${{ env.CHANNEL_PATH }}

This may work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a cf repack, so it must work now: https://anaconda.org/conda-forge/intel-opencl-rt

@ZzEeKkAa
Copy link
Collaborator

@oleksandr-pavlyk @diptorupd if we decide it is good to go with just dppy/label/dev and conda-forge dependency - we need to squash the PR. It's too many commits per small change.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZzEeKkAa ZzEeKkAa merged commit dc94b7e into main Aug 2, 2024
46 of 52 checks passed
@ZzEeKkAa ZzEeKkAa deleted the fix/github-workflows branch August 2, 2024 19:07
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Documentation preview removed.

github-actions bot added a commit that referenced this pull request Aug 2, 2024
Switch workflows to not use intel channel. dc94b7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install using conda
4 participants