Refactors and removes core.kernel interface #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
remove/core.kernel_interface
branch
from
d62a968
to
bea7e3f
Compare
ZzEeKkAa
reviewed
Apr 1, 2024
ZzEeKkAa
force-pushed
the
remove/core.kernel_interface
branch
3 times, most recently
from
c0375ea
to
9a3c871
Compare
- Merges core.kernel_interface.arrayobj into
kernel_api_impl.spirv.arrayobj
- Updated populate_array to use USMNdArray type.
- Remove core.kernel_api
Co-authored-by: Yevhenii Havrylko <[email protected]>
ZzEeKkAa
force-pushed
the
remove/core.kernel_interface
branch
from
9a3c871
to
725070e
Compare
ZzEeKkAa
approved these changes
Apr 2, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 2, 2024
Refactors and removes core.kernel interface ebc6c32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The features of
numba_dpex.core.kernel_interfaceare now subsumed by thekernel_api_implmodule and this PR completes the refactoring and removal of the legacy module.- Merges core.kernel_interface.arrayobj into kernel_api_impl.spirv.arrayobj
- Moves arrayobj.populate_array into target.py
- Updated populate_array to use USMNdArray type.
- Remove core.kernel_api