COMP: Fix compilation issue when using RelabelComponentImageFilter #4866
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Compiler
dzenanz
approved these changes
Oct 1, 2024
N-Dekker
reviewed
Oct 1, 2024
Modules/Segmentation/ConnectedComponents/include/itkRelabelComponentImageFilter.h
Outdated
Show resolved
Hide resolved
|
So SimpleITK has this filter instantiated with signed pixel types: But only returns std::vectors for these attributes and does not expose any If I recall correctly the original Watershed filter relied on signed pixel types and this filter. |
* Make arithmetic comparison safe with casting * Do not update parameter type to SizeValueType to avoid breaking public API Fixes InsightSoftwareConsortium#4865
kenavolic
force-pushed
the
fix_relabel_compilation_issue
branch
from
c82bc5d
to
108a2cf
Compare
dzenanz
approved these changes
Oct 2, 2024
|
For the record, the issue was originally discussed at https://discourse.itk.org/t/itk-getsizeofobjectinphysicalunits-signature/7237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4865
PR Checklist
There is a public API change as the parameter type is changed.
Refer to the ITK Software Guide for
further development details if necessary.