Skip to content

Commit

Permalink
ENH: Add itk::RelabelComponenetsImageFilter signedness test
Browse files Browse the repository at this point in the history
Add a test to check that the `itk::RelabelComponenetsImageFilter` class
does not trigger compiler warnings with signed pixel types.

Ensures regressions are not introduced after the fix in commit 108a2cf.
  • Loading branch information
jhlegarreta committed Oct 6, 2024
1 parent 9a5dade commit 24e8e63
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 0 deletions.
7 changes: 7 additions & 0 deletions Modules/Segmentation/ConnectedComponents/test/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
itk_module_test()
set(ITKConnectedComponentsTests
itkRelabelComponentImageFilterTest.cxx
itkRelabelComponentImageFilterSignednessTest.cxx
itkHardConnectedComponentImageFilterTest.cxx
itkConnectedComponentImageFilterTestRGB.cxx
itkConnectedComponentImageFilterTest.cxx
Expand All @@ -26,6 +27,12 @@ itk_add_test(
${ITK_TEST_OUTPUT_DIR}/RelabelComponentImageFilterTest.png
130
145)
itk_add_test(
NAME
itkRelabelComponentImageFilterSignednessTest
COMMAND
ITKConnectedComponentsTestDriver
itkRelabelComponentImageFilterSignednessTest)
itk_add_test(
NAME
itkHardConnectedComponentImageFilterTest
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*=========================================================================
*
* Copyright NumFOCUS
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0.txt
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*=========================================================================*/

#include "itkImage.h"
#include "itkRelabelComponentImageFilter.h"
#include "itkTestingMacros.h"


int
itkRelabelComponentImageFilterSignednessTest(int, char *[])
{

constexpr unsigned int Dimension = 3;
// Use a signed type
using PixelType = signed short;

using ImageType = itk::Image<PixelType, Dimension>;
using FilterType = itk::RelabelComponentImageFilter<ImageType, ImageType>;
using LabelType = FilterType::LabelType;

auto relabeler = FilterType::New();

// Call itk::RelabelComponentImageFilter methods to ensure that using a signed image does not raise any
// signedness compilation warning in them
LabelType label{};
itk::SizeValueType obj{};

ITK_TEST_EXPECT_EQUAL(0, relabeler->GetSizeOfObjectInPixels(label));
ITK_TEST_EXPECT_EQUAL(0, relabeler->GetSizeOfObjectInPixels(obj));

ITK_TEST_EXPECT_EQUAL(0, relabeler->GetSizeOfObjectInPhysicalUnits(label));
ITK_TEST_EXPECT_EQUAL(0, relabeler->GetSizeOfObjectInPhysicalUnits(obj));


std::cout << "Test finished." << std::endl;
return EXIT_SUCCESS;
}

0 comments on commit 24e8e63

Please sign in to comment.