Skip to content

Commit

Permalink
Merge pull request #599 from InseeFr/hot-fix-131
Browse files Browse the repository at this point in the history
Hot fix : get back to old editors from 1.2.0 version (Xpath)
  • Loading branch information
loichenninger authored May 18, 2022
2 parents d64d03f + ff1012d commit f71bc0c
Show file tree
Hide file tree
Showing 10 changed files with 35 additions and 14 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pogues",
"version": "1.3.0",
"version": "1.3.1",
"description": "Outil de conception et de test de questionnaires.",
"repository": {
"type": "git",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
import React from 'react';

import VTLEditor from './vtl-editor';
import TextareaWithSuggestions from './textarea-with-suggestions';
import RichTextareaWithSuggestions from './rich-textarea-with-suggestions';

import { FORMULA_LANGUAGE } from 'constants/pogues-constants';

const { XPATH, VTL } = FORMULA_LANGUAGE;

const RichEditor = ({ formulasLanguage, ...props }) => {
if (formulasLanguage === VTL) return <VTLEditor {...props} />;
if (formulasLanguage === XPATH) return <TextareaWithSuggestions {...props} />;
if (formulasLanguage === XPATH)
return <RichTextareaWithSuggestions {...props} />;
return null;
};

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import React from 'react';

import VTLEditor from './vtl-editor';
import TextareaWithSuggestions from './textarea-with-suggestions';

import { FORMULA_LANGUAGE } from 'constants/pogues-constants';

const { XPATH, VTL } = FORMULA_LANGUAGE;

const SimpleEditor = ({ formulasLanguage, ...props }) => {
if (formulasLanguage === VTL) return <VTLEditor {...props} />;
if (formulasLanguage === XPATH) return <TextareaWithSuggestions {...props} />;
return null;
};

export default SimpleEditor;
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import InputWithSuggestions from '../components/input-with-suggestions';
import TextareaWithSuggestions from '../components/textarea-with-suggestions';
import RichTextareaWithSuggestions from '../components/rich-textarea-with-suggestions';
import RichEditor from '../components/rich-editor';
import SimpleEditor from '../components/simple-editor';

export const InputWithSuggestionsContainer =
withCurrentFormVariables(InputWithSuggestions);
Expand All @@ -15,3 +16,5 @@ export const RichTextareaWithSuggestionsContainer = withCurrentFormVariables(
);

export const RichEditorContainer = withCurrentFormVariables(RichEditor);

export const SimpleEditorContainer = withCurrentFormVariables(SimpleEditor);
1 change: 1 addition & 0 deletions src/forms/controls/control-with-suggestions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ export {
TextareaWithSuggestionsContainer as TextareaWithVariableAutoCompletion,
RichTextareaWithSuggestionsContainer as RichTextareaWithVariableAutoCompletion,
RichEditorContainer as RichEditorWithVariable,
SimpleEditorContainer as SimpleEditorWithVariable,
} from './containers/control-with-suggestions-container';
4 changes: 2 additions & 2 deletions src/widgets/codes-lists/components/codes-lists.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import ListRadios from 'forms/controls/list-radios';
import Select from 'forms/controls/select';
import GenericOption from 'forms/controls/generic-option';
import { storeToArray, uuid } from 'utils/utils';
import { RichEditorWithVariable } from 'forms/controls/control-with-suggestions';
import { InputWithVariableAutoCompletion } from 'forms/controls/control-with-suggestions';

import { SearchCodesLists } from 'widgets/search-codes-lists';
import { ErrorsPanel } from 'widgets/errors-panel';
Expand Down Expand Up @@ -181,7 +181,7 @@ const CodesList = props => {
<ErrorsPanel path={`${selectorPathParent}.${selectorPath}`} />
<Field
name="label"
component={RichEditorWithVariable}
component={InputWithVariableAutoCompletion}
type="text"
label={Dictionary.newCl}
focusOnInit
Expand Down
6 changes: 3 additions & 3 deletions src/widgets/component-new-edit/components/controls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { defaultState } from 'model/formToState/component-new-edit/control';
import Select from 'forms/controls/select';
import GenericOption from 'forms/controls/generic-option';
import Textarea from 'forms/controls/textarea';
import { RichEditorWithVariable } from 'forms/controls/control-with-suggestions';
import { SimpleEditorWithVariable } from 'forms/controls/control-with-suggestions';

import { validateControlForm } from 'utils/validation/validate';
import Dictionary from 'utils/dictionary/dictionary';
Expand Down Expand Up @@ -60,14 +60,14 @@ const Controls = ({ formName, selectorPath, errors, addErrors }) => {
/>
<Field
name="condition"
component={RichEditorWithVariable}
component={SimpleEditorWithVariable}
label={Dictionary.expression}
required
setDisableValidation={setDisableValidation}
/>
<Field
name="message"
component={RichEditorWithVariable}
component={SimpleEditorWithVariable}
label={Dictionary.control_message}
required
setDisableValidation={setDisableValidation}
Expand Down
4 changes: 2 additions & 2 deletions src/widgets/component-new-edit/components/nestedFilter.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { WIDGET_COMPONENT_NEW_EDIT } from 'constants/dom-constants';
import Dictionary from 'utils/dictionary/dictionary';
import { uuid } from 'utils/utils';
import * as rules from 'forms/validation-rules';
import { RichEditorWithVariable } from 'forms/controls/control-with-suggestions';
import { InputWithVariableAutoCompletion } from 'forms/controls/control-with-suggestions';

const {
COMPONENT_CLASS,
Expand Down Expand Up @@ -455,7 +455,7 @@ const NestedFilter = props => {
</div>
</div>
<div>
<RichEditorWithVariable
<InputWithVariableAutoCompletion
input={{
name: 'filter',
onChange,
Expand Down
4 changes: 2 additions & 2 deletions src/widgets/component-new-edit/components/redirections.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { defaultState } from 'model/formToState/component-new-edit/redirection';

import { ListWithInputPanel } from 'widgets/list-with-input-panel';
import { GotoInput } from 'widgets/goto-input';
import { RichEditorWithVariable } from 'forms/controls/control-with-suggestions';
import { SimpleEditorWithVariable } from 'forms/controls/control-with-suggestions';
import Textarea from 'forms/controls/textarea';
import { validateRedirectionForm } from 'utils/validation/validate';

Expand Down Expand Up @@ -79,7 +79,7 @@ const Redirections = ({
<Field
type="text"
name="condition"
component={RichEditorWithVariable}
component={SimpleEditorWithVariable}
label={Dictionary.condition}
required
setDisableValidation={setDisableValidation}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import { defaultState } from 'model/formToState/component-new-edit/calculated-variable';

import Input from 'forms/controls/input';
import { RichEditorWithVariable } from 'forms/controls/control-with-suggestions';
import { SimpleEditorWithVariable } from 'forms/controls/control-with-suggestions';
import { ListWithInputPanel } from 'widgets/list-with-input-panel';
import { validateCalculatedVariableForm } from 'utils/validation/validate';
import ResponseFormatDatatypeNumeric from 'widgets/component-new-edit/components/response-format/simple/simple-numeric';
Expand Down Expand Up @@ -90,7 +90,7 @@ const CalculatedVariables = ({
<Field
name="formula"
type="text"
component={RichEditorWithVariable}
component={SimpleEditorWithVariable}
label={Dictionary.formula}
required
setDisableValidation={setDisableValidation}
Expand Down

0 comments on commit f71bc0c

Please sign in to comment.