unify signatures of createComponent (from action/components and actio…

…n/component)
InseeFr · Apr 18, 2023 · d3cfa75 · d3cfa75
1 parent 837664e
commit d3cfa75
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/actions/components.js b/src/actions/components.js
@@ -38,10 +38,10 @@ export const MOVE_COMPONENT = 'MOVE_COMPONENT';
 export const createComponent =
   (
     componentState,
-    codesListsStore,
     calculatedVariablesStore,
     externalVariablesStore,
     collectedVariablesStore,
+    codesListsStore,
   ) =>
   dispatch => {
     const activeComponentsStore = {

diff --git a/src/layout/component-new/components/component-new.jsx b/src/layout/component-new/components/component-new.jsx
@@ -73,10 +73,10 @@ function validateAndSubmit(
     actions
       .createComponent(
         componentState,
-        updatedCodesListsStore,
         updatedCalculatedVariablesStore,
         updatedExternalVariablesStore,
         updatedCollectedlVariablesStore,
+        updatedCodesListsStore,
       )
       .then(actions.updateParentChildren)
       .then(actions.orderComponents)

diff --git a/src/layout/questionnaire-list-components/components/questionnaire-component.jsx b/src/layout/questionnaire-list-components/components/questionnaire-component.jsx
@@ -157,7 +157,7 @@ const QuestionnaireComponent = props => {
                   componentFiltersInitial.map(filter => {
                     return (
                       <div
-                        key={`${filter}-if`}
+                        key={`${filter.id}-if`}
                         className="questionnaire-element-filter"
                       >
                         <button
@@ -173,7 +173,7 @@ const QuestionnaireComponent = props => {
                   componentFiltersFinal.map(filter => {
                     return (
                       <div
-                        key={`${filter}-endif`}
+                        key={`${filter.id}-endif`}
                         className="questionnaire-element-filter"
                       >
                         <button

diff --git a/src/layout/questionnaire-list/components/questionnaire-list.jsx b/src/layout/questionnaire-list/components/questionnaire-list.jsx
@@ -96,10 +96,10 @@ const QuestionnaireList = props => {
     };
     createComponent(
       componentState,
-      codesListsStore,
       calculatedVariablesStore,
       externalVariablesStore,
       collectedVariablesStore,
+      codesListsStore,
     )
       .then(updateParentChildren)
       .then(orderComponents)