638 nbspimplmenter le nouveau mcanisme pour le module dataset cot back ajouter des tests si non prsent #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-module-dataset-cot-back-ajouter-des-tests-si-non-prsent
- Limit dependencies to userProvider to security layer - Reduce dependency over deprecated class StampRestrictionServiceImpl
- less coupling - more tests case for access control - parametrized tests
- Un utilisateur avec la stratégie STAMP ne peut créer de ressource que pour son timbre - Un utilisateur avec la stratégie ALL peut créer des ressources pour n'importe quel timbre
…le-module-dataset-cot-back-ajouter-des-tests-si-non-prsent
FBibonne
requested changes
Aug 19, 2024
| @@ -19,6 +19,7 @@ | |||
| import org.springframework.http.HttpStatus; | |||
| import org.springframework.http.ResponseEntity; | |||
| import org.springframework.security.access.prepost.PreAuthorize; | |||
| import org.springframework.security.core.annotation.AuthenticationPrincipal; | |||
| @@ -38,28 +39,31 @@ public DatasetResources(DatasetService datasetService) { | |||
| this.datasetService = datasetService; | |||
| } | |||
|
|
|||
| // @PreAuthorize("canReadDataset(#datasetId)") | |||
There was a problem hiding this comment.
C'est bien l'annotation attendue. Pourquoi la commenter ?
| @GetMapping(produces = "application/json") | ||
| @Operation(operationId = "getDatasets", summary = "List of datasets", | ||
| responses = {@ApiResponse(content = @Content(array = @ArraySchema(schema = @Schema(implementation = Dataset.class))))}) | ||
| public String getDatasets() throws RmesException { | ||
| return this.datasetService.getDatasets(); | ||
| } | ||
|
|
||
| // @PreAuthorize("canReadDataset(#datasetId)") |
There was a problem hiding this comment.
C'est bien l'annotation attendue. Pourquoi la commenter ?
| @GetMapping(value = "/{id}", produces = "application/json") | ||
| @Operation(operationId = "getDataset", summary = "Get a dataset", | ||
| responses = {@ApiResponse(content = @Content(array = @ArraySchema(schema = @Schema(implementation = Dataset.class))))}) | ||
| public String getDataset(@PathVariable(Constants.ID) String id) throws RmesException { | ||
| return this.datasetService.getDatasetByID(id); | ||
| } | ||
|
|
||
| // @PreAuthorize("canReadDataset(#datasetId)") |
There was a problem hiding this comment.
C'est bien l'annotation attendue. Pourquoi la commenter ?
| } | ||
|
|
||
| @Override | ||
| public boolean userStampIsAuthorizedForResource(Module module, String id, Stamp stamp) { |
There was a problem hiding this comment.
Clarify names of modules (constants of enum Module) to fit with authorization methods of this class.
|
|
@HugoBouttes what is the status of this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#638