Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pizza exports list page #148

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add pizza exports list page #148

wants to merge 3 commits into from

Conversation

floflo0
Copy link
Member

@floflo0 floflo0 commented Oct 28, 2024

Description

Add a page in the admin to manage the pizza exports.

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • [X ] I have added labels to the pull request, if necessary.

Related Issues

Fix #119

Screenshots

2024-10-28-185006_hyprshot

@floflo0 floflo0 added the enhancement New feature or request label Oct 28, 2024
@floflo0 floflo0 requested a review from KwikKill October 28, 2024 17:56
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, just a design detail and a feature request.
Could also be delayed if you want.

src/views/AdminPizza/AdminPizzaExportList.vue Show resolved Hide resolved
class="hover:bg-cyan-800"
:class="{ hidden: !timeslotsExpand[timeslot.id] }"
>
<div class="flex select-none items-center gap-2 p-2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, but in addition to viewing exports and being able to delete them, I think we could add a download button.
This could be useful if the team need to download again or from another PC the export.
This require a new endpoint tho. What do you think about it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but we can do it later and push this in prod for the next mini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage exports from fronts
2 participants