Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Table "no rows to show" - text alignment fixed + continued enhancements for advanced table #988

Open
wants to merge 86 commits into
base: master
Choose a base branch
from

Conversation

verena-ifx
Copy link
Contributor

@verena-ifx verena-ifx commented Feb 6, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Text alignment fixed
Table demonstration in example apps fixed

📦 Published PR as canary version: 24.6.1--canary.988.71edf246d3750bed7937a414c99c1116fb0e4332.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@24.6.1--canary.988.71edf246d3750bed7937a414c99c1116fb0e4332.0
# or 
yarn add @infineon/infineon-design-system-stencil@24.6.1--canary.988.71edf246d3750bed7937a414c99c1116fb0e4332.0

@verena-ifx verena-ifx linked an issue Feb 6, 2024 that may be closed by this pull request
@verena-ifx verena-ifx added the patch patch version bump label Feb 6, 2024
@verena-ifx verena-ifx self-assigned this Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://Infineon.github.io/infineon-design-system-stencil/pr-preview-react-example/pr-988/
on branch gh-pages at 2024-08-23 13:29 UTC

Copy link
Contributor

github-actions bot commented Feb 6, 2024

--STORYBOOK-PREVIEW--

@verena-ifx verena-ifx changed the title Bugfix: Table "no rows to show" - text alignment fixed Bugfix: Table "no rows to show" - text alignment fixed + continued enhancements for advanced table Feb 12, 2024
@tishoyanchev
Copy link
Contributor

  • What is the purpose of the time showing when no rows or cols?
  • Can you create internal states for columnDefs, rowData?
  • Can you move gridApi into componentWillLoad to prevent risk of infinite re-renders?
  • Should we not include the advanced table in the example apps?
  • In React, when I remove rows, I get an error: Unexpected value for cols and rows: undefined ... If I remove
    the cols, I get: Unexpected value for cols and rows: .. and Unexpected value for cols: undefined

@verena-ifx verena-ifx linked an issue Feb 18, 2024 that may be closed by this pull request
@tishoyanchev
Copy link
Contributor

@verena-ifx
1 - chip is wrong
2 - enable-filtering is not needed. Why not just filter=sidebar/topbar/none?
3 - why not integrate the filter search inside?
4 - the filter-columns should not have 'search' and don't understand what is 'filter-name'? why is there a need to choose
the type? single/multi-select? why do the options contain so many properties?

@verena-ifx
Copy link
Contributor Author

verena-ifx commented Jul 29, 2024

inside

  • what do you mean with filter search inside?
  • the filtering can happen with single- or multiselect, based on the templates. and that makes sense in my opinion as well.
    filter-name and search define the mapping of the column to the table columns

@tishoyanchev
Copy link
Contributor

tishoyanchev commented Aug 9, 2024

@verena-ifx

  • Can you resolve the merge conflicts?
  • Can componentDidLoad() { this.updateVisibleSlots(); } be invoked in componentWillLoad() instead?
  • Is filter-type-group a separate stand-alone component? If not, then you have to remove it from Storybook. Also, if filter-bar is not going to be a stand-alone component, then both should be inside the advanced-table-version folder, no?
  • Can you add it in the example apps? Right now, only the 'show filters' button is there, but when you click it, the filter is not there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch patch version bump
Development

Successfully merging this pull request may close these issues.

Text inside table collides with table-header Set Filter for Table component
2 participants