You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verena-ifx
changed the title
Bugfix: Table "no rows to show" - text alignment fixed
Bugfix: Table "no rows to show" - text alignment fixed + continued enhancements for advanced table
Feb 12, 2024
What is the purpose of the time showing when no rows or cols?
Can you create internal states for columnDefs, rowData?
Can you move gridApi into componentWillLoad to prevent risk of infinite re-renders?
Should we not include the advanced table in the example apps?
In React, when I remove rows, I get an error: Unexpected value for cols and rows: undefined ... If I remove
the cols, I get: Unexpected value for cols and rows: .. and Unexpected value for cols: undefined
@verena-ifx
1 - chip is wrong
2 - enable-filtering is not needed. Why not just filter=sidebar/topbar/none?
3 - why not integrate the filter search inside?
4 - the filter-columns should not have 'search' and don't understand what is 'filter-name'? why is there a need to choose
the type? single/multi-select? why do the options contain so many properties?
the filtering can happen with single- or multiselect, based on the templates. and that makes sense in my opinion as well.
filter-name and search define the mapping of the column to the table columns
Can componentDidLoad() { this.updateVisibleSlots(); } be invoked in componentWillLoad() instead?
Is filter-type-group a separate stand-alone component? If not, then you have to remove it from Storybook. Also, if filter-bar is not going to be a stand-alone component, then both should be inside the advanced-table-version folder, no?
Can you add it in the example apps? Right now, only the 'show filters' button is there, but when you click it, the filter is not there.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Text alignment fixed
Table demonstration in example apps fixed
📦 Published PR as canary version:
24.6.1--canary.988.71edf246d3750bed7937a414c99c1116fb0e4332.0
✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@24.6.1--canary.988.71edf246d3750bed7937a414c99c1116fb0e4332.0 # or yarn add @infineon/infineon-design-system-stencil@24.6.1--canary.988.71edf246d3750bed7937a414c99c1116fb0e4332.0