You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added events that emit the value of the selected option in the dropdown-menu.
The event is emitted from dropdown-item, captured in dropdown-menu, and then re-emitted again.
📦 Published PR as canary version: 20.16.3--canary.455.cf6a720b771d8f7b3b2a99ccd9941de15d3a4c6a.0
✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@20.16.3--canary.455.cf6a720b771d8f7b3b2a99ccd9941de15d3a4c6a.0
# or
yarn add @infineon/infineon-design-system-stencil@20.16.3--canary.455.cf6a720b771d8f7b3b2a99ccd9941de15d3a4c6a.0
Could you change the story name, so the dropdown-menu doesnt appear anymore under "Not reviewed" on Storybook?
Or should I do it?
Another thing missing is the action on storybook, so the user can see which events get emitted and what they contain
Could you change the story name, so the dropdown-menu doesnt appear anymore under "Not reviewed" on Storybook? Or should I do it? Another thing missing is the action on storybook, so the user can see which events get emitted and what they contain
You can fix those if you have the time so I can focus on the other high-priority issues.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
I have added events that emit the value of the selected option in the dropdown-menu.
The event is emitted from dropdown-item, captured in dropdown-menu, and then re-emitted again.
📦 Published PR as canary version:
20.16.3--canary.455.cf6a720b771d8f7b3b2a99ccd9941de15d3a4c6a.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@20.16.3--canary.455.cf6a720b771d8f7b3b2a99ccd9941de15d3a4c6a.0 # or yarn add @infineon/infineon-design-system-stencil@20.16.3--canary.455.cf6a720b771d8f7b3b2a99ccd9941de15d3a4c6a.0