added dropdown-menu to breadcrumb #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
--STORYBOOK-PREVIEW--
|
|
--EXAMPLE-APPS-PREVIEW--
|
tishoyanchev
added
patch
|
could you add the Breadcrumb to the example apps? |
…ithub.com:Infineon/infineon-design-system-stencil into 442-breadcrumbs-dropdown-menu-needs-to-be-updated
|
|
verena-ifx
deleted the
442-breadcrumbs-dropdown-menu-needs-to-be-updated
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
Due to changes in the dropdown component, the breadcrumb needed to be updated in order to account for the new changes introduced in the dropdown-menu component.
Changes:
1 - Dropdown now uses a Prop (isOpen) to add and remove 'show' class which opens and closes the menu.
2 - Breadcrumbs component toggles the wrapper of the dropdown-menu, and therefore requires that the dropdown-menu is opened at all times.
3 - I simply use the new isOpen Prop to set "open" the menu on componentDidLoad inside the breadcrumbs component. The toggling of the dropdown-menu wrapper remains unchanged.
📦 Published PR as canary version:
20.16.5--canary.453.3201cafb1c229e9af1ec9682f5e5068b2b930925.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@20.16.5--canary.453.3201cafb1c229e9af1ec9682f5e5068b2b930925.0 # or yarn add @infineon/infineon-design-system-stencil@20.16.5--canary.453.3201cafb1c229e9af1ec9682f5e5068b2b930925.0