Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

247 implementation pagination #426

Merged
merged 33 commits into from
Sep 13, 2023
Merged

Conversation

tishoyanchev
Copy link
Contributor

@tishoyanchev tishoyanchev commented Aug 28, 2023

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

The Pagination component.

!Do not merge!

📦 Published PR as canary version: 20.21.0--canary.426.063cd0fa02ceacc75d8756ca00ce1e5836f72724.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@20.21.0--canary.426.063cd0fa02ceacc75d8756ca00ce1e5836f72724.0
# or 
yarn add @infineon/infineon-design-system-stencil@20.21.0--canary.426.063cd0fa02ceacc75d8756ca00ce1e5836f72724.0

@tishoyanchev tishoyanchev linked an issue Aug 28, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-13 07:41 UTC

@github-actions
Copy link
Contributor

--STORYBOOK-PREVIEW--

@verena-ifx verena-ifx added the minor minor version bump label Aug 28, 2023
@verena-ifx
Copy link
Contributor

verena-ifx commented Sep 5, 2023

it would be useful in the example apps to link the pagination to actual elements. So you could create 30 divs with text for example, and then demonstrate a use case with that?
not sure if its obvious for the user how to use it like this?

@tishoyanchev
Copy link
Contributor Author

tishoyanchev commented Sep 6, 2023

it would be useful in the example apps to link the pagination to actual elements. So you could create 30 divs with text for example, and then demonstrate a use case with that? not sure if its obvious for the user how to use it like this?

This makes sense, yes, but it requires some efforts, and we have more high-priority tasks. So, I will write it in the backlog, and let's merge this PR now if there are no issues.

@verena-ifx
Copy link
Contributor

no events emitted visibly to the user (storybook)

@verena-ifx
Copy link
Contributor

@tishoyanchev can you please check my latest changes in the react example app? the pagination is not working as it should when using some simple mock data

@verena-ifx
Copy link
Contributor

please resolve merge conflicts first

@verena-ifx verena-ifx merged commit 69aa8af into master Sep 13, 2023
8 checks passed
@verena-ifx verena-ifx deleted the 247-implementation-pagination branch September 13, 2023 07:39
@github-actions
Copy link
Contributor

🚀 PR was released in v20.21.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor version bump released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation: Pagination
2 participants