Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added badge doc #294

Merged
merged 3 commits into from
Jul 21, 2023
Merged

added badge doc #294

merged 3 commits into from
Jul 21, 2023

Conversation

SergejLust
Copy link
Contributor

@SergejLust SergejLust commented Jul 21, 2023

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Provide the information we need to review your PR. What problem does the pull request solve? "Bug fix" is not a good description.

Related Issue
If you opened an issue before creating the PR, point to it here.

Context
What do we need to know about your development environment, tools, target, and so on. Screenshots are always helpful if there is a UI element to this PR.

📦 Published PR as canary version: 18.5.2--canary.294.d5cedd725a87f89529883628a303a0afb05e3df4.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@18.5.2--canary.294.d5cedd725a87f89529883628a303a0afb05e3df4.0
# or 
yarn add @infineon/infineon-design-system-stencil@18.5.2--canary.294.d5cedd725a87f89529883628a303a0afb05e3df4.0

@SergejLust SergejLust linked an issue Jul 21, 2023 that may be closed by this pull request
…n-design-system-stencil into 234-documentation-badge
@SergejLust
Copy link
Contributor Author

@verena-ifx Ive got issues with creating a PR.

@verena-ifx
Copy link
Contributor

@SergejLust Storybook wasnt building, cause the path to the image file was missing the file extension:
I added the ".png" here:
import BadgeDafault from '../../../public-storybook/images/badge/badge-default.png';

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-21 13:11 UTC

@verena-ifx
Copy link
Contributor

Looks good to me, can I merge it already?

@verena-ifx verena-ifx merged commit 9f37b99 into master Jul 21, 2023
3 checks passed
@verena-ifx verena-ifx deleted the 234-documentation-badge branch July 21, 2023 13:09
@github-actions
Copy link
Contributor

🚀 PR was released in v18.5.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Badge
2 participants