Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewed and updated tag #269

Merged
merged 6 commits into from
Jul 17, 2023
Merged

reviewed and updated tag #269

merged 6 commits into from
Jul 17, 2023

Conversation

tishoyanchev
Copy link
Contributor

@tishoyanchev tishoyanchev commented Jul 17, 2023

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Reviewed the Tag component, and changed/updated the following:

  • added e2e test
  • added it to example apps (including Vanilla and Angular)
  • Changed the label from being a Prop to being nested.
  • Updated the changes to Storybook
📦 Published PR as canary version: 18.3.0--canary.269.708b05b7ba4e54b32c8a64cd7fe745655ed75289.1

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@18.3.0--canary.269.708b05b7ba4e54b32c8a64cd7fe745655ed75289.1
# or 
yarn add @infineon/infineon-design-system-stencil@18.3.0--canary.269.708b05b7ba4e54b32c8a64cd7fe745655ed75289.1

@tishoyanchev tishoyanchev linked an issue Jul 17, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-17 14:36 UTC

verena-ifx added 2 commits July 17, 2023 15:34
@verena-ifx verena-ifx added the minor minor version bump label Jul 17, 2023
@verena-ifx
Copy link
Contributor

fixed some merge conflicts and added headers to the example apps in Vue.

@verena-ifx verena-ifx merged commit 2b6b72a into master Jul 17, 2023
8 checks passed
@verena-ifx verena-ifx deleted the 208-review-tag branch July 17, 2023 14:33
@github-actions
Copy link
Contributor

🚀 PR was released in v18.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor version bump released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review: Tag
2 participants