252 fix navbar component position inconsistency #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Preview URLs:
|
verena-ifx
reviewed
Jul 21, 2023
verena-ifx
reviewed
Jul 21, 2023
| @@ -1,74 +1,10 @@ | |||
| import './App.css'; | |||
| import Alert from './components/Alert.vue' | |||
There was a problem hiding this comment.
There are a bunch of errors because the imports are wrong. They are .vue imports => Please test next time before committing.
|
I saw the navbar has a white background, just noticed that in case of Angular, the default background is something greyish and that looks weird with a white navbar. Will take that to the next backlog refinement meeting |
…tency; added Navbar to all the example apps; fixed some import path errors
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
📦 Published PR as canary version:
18.4.1--canary.256.8a2cafa5f3d9012fe2e675d17283dfdda6e12d8c.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@18.4.1--canary.256.8a2cafa5f3d9012fe2e675d17283dfdda6e12d8c.0 # or yarn add @infineon/infineon-design-system-stencil@18.4.1--canary.256.8a2cafa5f3d9012fe2e675d17283dfdda6e12d8c.0