Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

191 review spinner #214

Merged
merged 6 commits into from
Jul 10, 2023
Merged

191 review spinner #214

merged 6 commits into from
Jul 10, 2023

Conversation

tishoyanchev
Copy link
Contributor

@tishoyanchev tishoyanchev commented Jun 27, 2023

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

The Spinner component reviewed and updated:

  • added semiconductor icon
  • added small size for semiconductor icon
  • added new icon variant to storybook
  • included it in the example apps
📦 Published PR as canary version: 18.2.13--canary.214.e963ef10aca1d57b34914d7a9edef7008bf73504.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@18.2.13--canary.214.e963ef10aca1d57b34914d7a9edef7008bf73504.0
# or 
yarn add @infineon/infineon-design-system-stencil@18.2.13--canary.214.e963ef10aca1d57b34914d7a9edef7008bf73504.0

@tishoyanchev tishoyanchev linked an issue Jun 27, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-10 07:51 UTC

@verena-ifx
Copy link
Contributor

e2e tests are missing, please add

@verena-ifx
Copy link
Contributor

  • Made some changes to the Vue wrapper example apps. Please make sure to follow the format of the existing components.
  • Examples for Vanilla + Angular are missing

@verena-ifx
Copy link
Contributor

Added the Spinner to the Angular and VanillaJs example applications. Tests passed, Component looks good. Can be merged

@verena-ifx verena-ifx merged commit 5eac660 into master Jul 10, 2023
@verena-ifx verena-ifx deleted the 191-review-spinner branch July 10, 2023 07:47
@github-actions
Copy link
Contributor

🚀 PR was released in v18.2.13 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review: Spinner
2 participants