Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

160 e2e tests #197

Merged
merged 4 commits into from
Jun 19, 2023
Merged

160 e2e tests #197

merged 4 commits into from
Jun 19, 2023

Conversation

verena-ifx
Copy link
Contributor

@verena-ifx verena-ifx commented Jun 16, 2023

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

e2e tests added to:

  • alert
  • badge
  • button
  • card (+ card-headline + card-overline)
  • checkbox
  • footer-column
📦 Published PR as canary version: 18.2.5--canary.197.02f43862fb7f9ff98d63bc8136f91e0e26d17dcb.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@18.2.5--canary.197.02f43862fb7f9ff98d63bc8136f91e0e26d17dcb.0
# or 
yarn add @infineon/infineon-design-system-stencil@18.2.5--canary.197.02f43862fb7f9ff98d63bc8136f91e0e26d17dcb.0

@verena-ifx verena-ifx self-assigned this Jun 16, 2023
@verena-ifx verena-ifx linked an issue Jun 16, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-19 14:02 UTC

PR Preview URL for Storybook: https://Infineon.github.io/infineon-design-system-stencil/pr-preview/pr-197/

@tishoyanchev
Copy link
Contributor

I ran npm run test inside packages/components, and I got a few errors.
Alert: Icon not found!
It seems that inside the alert.e2e.ts, you have this line: but 'checkmark' is invalid icon name. We have c-check-16, but not checkmark.

checkbox.e2e.ts
console.warn
STENCIL: The state/prop "hasSlot" changed during rendering. This can potentially lead to infinite-loops and other bugs.

card-headline:
console.error
JSHandle@error

@tishoyanchev tishoyanchev merged commit 60415c0 into master Jun 19, 2023
@github-actions
Copy link
Contributor

🚀 PR was released in v18.2.5 🚀

@verena-ifx verena-ifx deleted the 160-e2e-tests branch August 2, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests for components
2 participants