-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion issues fixed #178
Conversation
PR Preview URL for React example: https://Infineon.github.io/infineon-design-system-stencil/pr-preview-react-example/pr-178/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! two small things
@Listen('ifxItemOpen') | ||
async onItemOpen(event: CustomEvent) { | ||
const items = Array.from(this.el.querySelectorAll('ifx-accordion-item')); | ||
if(this.autoCollapse) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small performance fix: move this line one layer up so we don't query when auto collapse is false
🚀 PR was released in |
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
Fixes the following issues with the Accordion:
multiple lines, instead, it overflows, but the overflow is just hidden. It should break into another line.
there are no changes to the open property.
margin: 0;
padding: 0;
}
the component should not style this paragraph, since it is not a given that it will be in the
accordion-item. Users may just add text without
. The
is not explicetly part of the
component.
display: block;
}
:host { display : block; } is not needed.
📦 Published PR as canary version:
18.2.4--canary.178.465a39746b1762aff99655414a8cf5e542dc0105.0
✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@18.2.4--canary.178.465a39746b1762aff99655414a8cf5e542dc0105.0 # or yarn add @infineon/infineon-design-system-stencil@18.2.4--canary.178.465a39746b1762aff99655414a8cf5e542dc0105.0