Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: fixed storybook page bug #1482

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Tabs: fixed storybook page bug #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f58a0c9
docs(1477): fix errors in tab component story
akashyeole Sep 19, 2024
856249b
Merge f58a0c94c5b9317f95d37e77cf2133553c3b4b3d into 42343834babaf445d…
akashyeole Sep 19, 2024
17aa636
Update Stencil library version to 25.1.1--canary.1482.856249b100a6641…
invalid-email-address Sep 19, 2024
aa1eb86
fix(1477): merge master branch
akashyeole Oct 1, 2024
bd53259
Merge aa1eb8650a16ec3adef269c00a2ab0841f4d3c32 into 310a4ea8956da7302…
akashyeole Oct 1, 2024
82bf0bd
Update Stencil library version to 25.2.3--canary.1482.bd53259df81a6f5…
invalid-email-address Oct 1, 2024
f01a05b
Merge branch 'master' into 1477-tabs-error-when-number-of-tabs-is-inc…
tishoyanchev Oct 2, 2024
6df06fe
Merge f01a05b3f2906becdb3b5d82b04288cbbb8ad35f into b9b03249b416d0513…
akashyeole Oct 2, 2024
cc2ddf0
Update Stencil library version to 25.4.1--canary.1482.6df06fe46baba84…
invalid-email-address Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"version": "25.4.0",
"version": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0",
"command": {
"publish": {
"verifyAccess": false
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/components-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "components-angular",
"version": "25.4.0",
"version": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
Expand All @@ -26,7 +26,7 @@
"@angular/platform-browser": "^18.0.0",
"@angular/platform-browser-dynamic": "^18.0.0",
"@angular/router": "^18.0.0",
"@infineon/infineon-design-system-angular": "^25.4.0",
"@infineon/infineon-design-system-angular": "^25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0",
"rxjs": "~7.8.0",
"tslib": "^2.3.0",
"typescript": "~5.4.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/components-angular/projects/component-library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-angular",
"version": "25.4.0",
"version": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0",
"description": "Infineon design system Stencil web components for Angular",
"author": "Verena Lechner",
"license": "MIT",
Expand All @@ -11,7 +11,7 @@
"@angular/common": "^18.0.0",
"@angular/core": "^18.0.0",
"@infineon/design-system-tokens": "3.3.3",
"@infineon/infineon-design-system-stencil": "25.4.0"
"@infineon/infineon-design-system-stencil": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/components-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-react",
"version": "25.4.0",
"version": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0",
"description": "Infineon design system Stencil web components for React",
"main": "./dist/index.js",
"types": "./dist/types/index.d.ts",
Expand Down Expand Up @@ -28,7 +28,7 @@
},
"dependencies": {
"@infineon/design-system-tokens": "3.3.3",
"@infineon/infineon-design-system-stencil": "25.4.0"
"@infineon/infineon-design-system-stencil": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0"
},
"auto": {
"plugins": [
Expand Down
4 changes: 2 additions & 2 deletions packages/components-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-vue",
"version": "25.4.0",
"version": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0",
"description": "Infineon design system Stencil web components for Vue",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down Expand Up @@ -31,7 +31,7 @@
},
"dependencies": {
"@infineon/design-system-tokens": "3.3.3",
"@infineon/infineon-design-system-stencil": "25.4.0"
"@infineon/infineon-design-system-stencil": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0"
},
"auto": {
"plugins": [
Expand Down
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@infineon/infineon-design-system-stencil",
"version": "25.4.0",
"version": "25.4.1--canary.1482.6df06fe46baba84acad1a14d976f35ab2142c6f7.0",
"private": false,
"description": "Infineon design system Stencil web components",
"homepage": "https://infineon.github.io/infineon-design-system-stencil",
Expand Down
21 changes: 4 additions & 17 deletions packages/components/src/components/tabs/tabs.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,5 @@
import { action } from '@storybook/addon-actions';

const tabHeaders = [
{
header: 'tab a',
disabled: false,
},
{
header: 'tab b',
disabled: true,
},
{
header: 'tab c',
disabled: false,
},
];

export default {
title: 'Components/Tabs',
tags: ['autodocs'],
Expand Down Expand Up @@ -64,8 +49,10 @@ const Template = args => {

for (let i = 0; i < args.amountOfTabs; i++) {
const tabContent = document.createElement('ifx-tab');
tabContent.setAttribute('header', tabHeaders[i].header);
tabContent.setAttribute('disabled', tabHeaders[i].disabled.toString());
tabContent.setAttribute('header', `tab ${i+1}`);
if(i == 1) {
tabContent.setAttribute('disabled', 'true');
}
if(args.icon){
tabContent.setAttribute('icon', 'c-check-16');
tabContent.setAttribute('icon-position', args.iconPosition);
Expand Down
Loading