Sidebar: number-indicator not showing anymore when empty

[akashyeole]

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Changed property height >>> max-height .

Related Issue
Closes #1478

📦 Published PR as canary version: 25.6.4--canary.1481.73e1ba0d587d8501e7e6c61d263333d311c43ca7.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@25.6.4--canary.1481.73e1ba0d587d8501e7e6c61d263333d311c43ca7.0
# or 
yarn add @infineon/infineon-design-system-stencil@25.6.4--canary.1481.73e1ba0d587d8501e7e6c61d263333d311c43ca7.0

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-03 12:42 UTC

[github-actions]

--STORYBOOK-PREVIEW--

• PR Preview URL for Storybook: https://Infineon.github.io/infineon-design-system-stencil/pr-preview/pr-1481/

[github-actions]

--EXAMPLE-APPS-PREVIEW--
PR Preview URLs:

• Vue example: https://Infineon.github.io/infineon-design-system-stencil/pr-preview-vue-example/pr-1481/
• React example: https://Infineon.github.io/infineon-design-system-stencil/pr-preview-react-example/pr-1481/
• Angular example: https://Infineon.github.io/infineon-design-system-stencil/pr-preview-angular-example/pr-1481/
• Vanilla example: https://Infineon.github.io/infineon-design-system-stencil/pr-preview-vanilla-example/pr-1481/

[tishoyanchev]

When number-indicator is empty, NaN is rendered.
number-indicator=""

[tishoyanchev]

Also, this condition is very unclear.
!this.numberIndicator !== undefined

[tishoyanchev]

Also, even when number-indicator is not set, its wrapper is still rendered in the DOM.

[tishoyanchev]

@akashyeole

• every sidebar-item instance throws an error
• sidebar__nav-item-indicator wrapper still occupies space even when number-indicator is not present.