Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: implemented disabled prop for ifx-step #1408

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

akashyeole
Copy link
Member

@akashyeole akashyeole commented Aug 5, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Description
Implemented the disabled prop for ifx-step component, when set, step cannot be clicked.
Updated the ifx-link variant to menu.

Related Issue
#1395
#1437

📦 Published PR as canary version: 25.1.0--canary.1408.606a0ef514777a8f6ff0c6a1ada0de71b7836db3.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@25.1.0--canary.1408.606a0ef514777a8f6ff0c6a1ada0de71b7836db3.0
# or 
yarn add @infineon/infineon-design-system-stencil@25.1.0--canary.1408.606a0ef514777a8f6ff0c6a1ada0de71b7836db3.0

@akashyeole akashyeole added the minor minor version bump label Aug 5, 2024
@akashyeole akashyeole self-assigned this Aug 5, 2024
@akashyeole akashyeole linked an issue Aug 5, 2024 that may be closed by this pull request
@akashyeole akashyeole changed the title Stepper: implemented disabled prop for ifx-step Stepper: implemented disabled prop for ifx-step Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://Infineon.github.io/infineon-design-system-stencil/pr-preview/pr-1408/
on branch gh-pages at 2024-09-13 12:17 UTC

Copy link
Contributor

github-actions bot commented Aug 5, 2024

--STORYBOOK-PREVIEW--

@tishoyanchev
Copy link
Contributor

@akashyeole
The disabled state is incorrect.

@verena-ifx
Copy link
Contributor

Is there any update on this @akashyeole ?

@akashyeole akashyeole marked this pull request as draft August 23, 2024 07:29
@akashyeole akashyeole marked this pull request as ready for review September 5, 2024 09:09
@tishoyanchev
Copy link
Contributor

@akashyeole
Did you make the changes from this Issue? #1437

@akashyeole akashyeole linked an issue Sep 10, 2024 that may be closed by this pull request
@tishoyanchev
Copy link
Contributor

Ready for merge.
Waiting for react issue to be fixed so all checks can pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: align design to latest changes Stepper: implement a disable Prop for each Step
3 participants