[Screencap] Rudimentary Profiles #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
|
Looks like this in the settings: |
ManlyMarco
reviewed
Sep 30, 2024
Comment on lines
+216
to
+219
| presetKeys.Add(Config.Bind("Presets", $"~{i + 1} - Shortcut", KeyboardShortcut.Empty, new ConfigDescription($"Keyboard Shortcut for Preset #{i + 1}.", null, "Advanced"))); | ||
| presetResX.Add(Config.Bind("Presets", $"~{i + 1} - Res Horizontal", Screen.width, new ConfigDescription($"Horizontal size (width) of rendered screenshots in pixels of Preset #{i + 1}.", new AcceptableValueRange<int>(ScreenshotSizeMin, ScreenshotSizeMax), "Advanced"))); | ||
| presetResY.Add(Config.Bind("Presets", $"~{i + 1} - Res Vertical", Screen.height, new ConfigDescription($"Vertical size (height) of rendered screenshots in pixels of Preset #{i + 1}.", new AcceptableValueRange<int>(ScreenshotSizeMin, ScreenshotSizeMax), "Advanced"))); | ||
| presetDownscaling.Add(Config.Bind("Presets", $"~{i + 1} - Upsampling Ratio", 2, new ConfigDescription($"Capture screenshots in a higher resolution and then downscale them to desired size for Preset #{i + 1}. Prevents aliasing, perserves small details and gives a smoother result, but takes longer to create.", new AcceptableValueRange<int>(1, 4), "Advanced"))); |
There was a problem hiding this comment.
Wouldn't it make more sense to include number of the preset in the category name? e.g. [Custom Hotkey 1]
Here's how I implemented something similar, a bit less user friendly though.
ManlyMarco
reviewed
Sep 30, 2024
Comment on lines
+79
to
+82
| public static List<ConfigEntry<KeyboardShortcut>> presetKeys { get; private set; } = new List<ConfigEntry<KeyboardShortcut>>(); | ||
| public static List<ConfigEntry<int>> presetResX { get; private set; } = new List<ConfigEntry<int>>(); | ||
| public static List<ConfigEntry<int>> presetResY { get; private set; } = new List<ConfigEntry<int>>(); | ||
| public static List<ConfigEntry<int>> presetDownscaling { get; private set; } = new List<ConfigEntry<int>>(); |
There was a problem hiding this comment.
I'd rather make a struct to hold all these config entries in a single list.
There was a problem hiding this comment.
Understandable, I can fix that 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rudimentary support for additional resolution presets, which can be bound to additional hotkey.
They are not a hotkey to change the settings, but rather additional settings, independent of the normal settings.
Because of that they do not benefit from recent improvements like the guide lines.