Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS12Z Symbol, Footprint, and 3D model #124

Merged
merged 4 commits into from
Nov 4, 2023
Merged

RS12Z Symbol, Footprint, and 3D model #124

merged 4 commits into from
Nov 4, 2023

Conversation

yummy-tofu
Copy link
Contributor

New symbol and stuff

@yummy-tofu yummy-tofu requested a review from a team as a code owner November 3, 2023 21:20
@github-actions github-actions bot added footprint changes to footprint libraries symbol changes to symbol libraries 3d model changes to a 3d model labels Nov 3, 2023
@yummy-tofu yummy-tofu self-assigned this Nov 3, 2023
@lukeag3
Copy link
Contributor

lukeag3 commented Nov 3, 2023

This definitely already exists

@lukeag3 lukeag3 closed this Nov 3, 2023
@lukeag3 lukeag3 reopened this Nov 3, 2023
@github-actions github-actions bot added the kicad libraries changes to kicad libraries files label Nov 3, 2023
@lukeag3 lukeag3 changed the title new footprints schematic and 3d. idk why lf files RS12Z Symbol, Footprint, and 3D model Nov 4, 2023
lukeag3
lukeag3 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@lukeag3 lukeag3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeag3 lukeag3 merged commit 7957312 into master Nov 4, 2023
1 check passed
@lukeag3 lukeag3 deleted the NewCANDCDC branch November 4, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeag3 lukeag3 lukeag3 approved these changes

@Achmiel4 Achmiel4 Awaiting requested review from Achmiel4

Assignees

@yummy-tofu yummy-tofu

Labels
3d model changes to a 3d model footprint changes to footprint libraries kicad libraries changes to kicad libraries files symbol changes to symbol libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yummy-tofu @lukeag3 @lukeg3