Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix components inappropriately marked as through-hole #120

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix components inappropriately marked as through-hole #120

merged 1 commit into from
Oct 17, 2023

Conversation

lukeag3
Copy link
Contributor

@lukeag3 lukeag3 commented Oct 17, 2023 •
edited
Loading

Some parts in v7 are marked as through-hole when they should be SMD, this causes DRC error. This PR fixes some of those parts

@lukeag3 lukeag3 requested a review from a team as a code owner October 17, 2023 04:21
@github-actions github-actions bot added the footprint changes to footprint libraries label Oct 17, 2023
ryderch2
ryderch2 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ryderch2 ryderch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lukeag3 lukeag3 merged commit 3126bab into master Oct 17, 2023
1 check passed
@lukeag3 lukeag3 deleted the v7_fixes branch October 17, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryderch2 ryderch2 ryderch2 approved these changes

@Achmiel4 Achmiel4 Awaiting requested review from Achmiel4

@AlexLymbo AlexLymbo Awaiting requested review from AlexLymbo

Assignees
No one assigned
Labels
footprint changes to footprint libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukeag3 @ryderch2 @lukeg3