refactor(pivot): move date dimension enabled set on init (#14754)

IgniteUI · Sep 16, 2024 · c59cdfe · c59cdfe
1 parent ad1d52c
commit c59cdfe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid-dimensions.ts b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid-dimensions.ts
@@ -128,7 +128,6 @@ export class IgxPivotDateDimension implements IPivotDimension {
     constructor(inBaseDimension: IPivotDimension = null, inOptions: IPivotDateDimensionOptions = {}) {
         this._baseDimension = inBaseDimension;
         this._options = inOptions;
-        this.enabled = inBaseDimension?.enabled;
         if (this.baseDimension && this.options) {
             this.initialize(this.baseDimension, this.options);
         }
@@ -140,6 +139,7 @@ export class IgxPivotDateDimension implements IPivotDimension {
         this.dataType = GridColumnDataType.Date;
         inBaseDimension.dataType = GridColumnDataType.Date;
 
+        this.enabled = inBaseDimension.enabled;
         this.displayName = inBaseDimension.displayName || this.resourceStrings.igx_grid_pivot_date_dimension_total;
 
         const baseDimension = options.fullDate ? inBaseDimension : null;

diff --git a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.spec.ts b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.spec.ts
@@ -2016,8 +2016,6 @@ describe('IgxPivotGrid #pivotGrid', () => {
             it('should allow creating  IgxPivotDateDimension with no base dimension and setting it later.', () => {
                 const pivotGrid = fixture.componentInstance.pivotGrid;
                 const dateDimension = new IgxPivotDateDimension();
-                dateDimension.memberName = 'Date';
-                dateDimension.enabled = true;
                 dateDimension.baseDimension = {
                     memberName: 'Date',
                     enabled: true,
@@ -2029,6 +2027,9 @@ describe('IgxPivotGrid #pivotGrid', () => {
                     years: true,
                     quarters: false
                 }
+
+                expect(dateDimension.enabled).toBe(true);
+
                 pivotGrid.pivotConfiguration.rows = [dateDimension];
                 pivotGrid.pipeTrigger++;
                 fixture.detectChanges();