Skip to content

Commit

Permalink
Localization applied to grid's editing row message (#14670)
Browse files Browse the repository at this point in the history
* fix(i18n): added igx_grid_row_edit_text

* fix(grid): added row edit text logic to all grid components

* fix(grid): Requested fixes from the review

---------

Co-authored-by: Bozhidara Pachilova <[email protected]>
  • Loading branch information
Zneeky and ddaribo authored Aug 29, 2024
1 parent b7409f8 commit 9792b4d
Show file tree
Hide file tree
Showing 26 changed files with 36 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsBG_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Разкачи всички',
igx_grid_row_edit_btn_done: 'Запази',
igx_grid_row_edit_btn_cancel: 'Откажи',
igx_grid_row_edit_text: 'Имате {0} промени на този ред и {1} скрити колони',
igx_grid_toolbar_actions_filter_prompt: 'Филтрирай списъка с колони...',
igx_grid_toolbar_pinning_button_tooltip: 'Отвори списъка със закачени колони.',
igx_grid_toolbar_hiding_button_tooltip: 'Отвори списъка със скрити колони.',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsCS_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Odepnout vše',
igx_grid_row_edit_btn_done: 'Hotovo',
igx_grid_row_edit_btn_cancel: 'Storno',
igx_grid_row_edit_text: 'V tomto řádku máte {0} změn a {1} skryté sloupce',
igx_grid_toolbar_actions_filter_prompt: 'Filtrovat seznam sloupců ...',
igx_grid_toolbar_pinning_button_tooltip: 'Otevřít rozevírací nabídku připnout sloupec',
igx_grid_toolbar_hiding_button_tooltip: 'Otevřít rozevírací nabídku skrýt sloupec',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsDA_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Frigør alle',
igx_grid_row_edit_btn_done: 'Færdig',
igx_grid_row_edit_btn_cancel: 'Annuller',
igx_grid_row_edit_text: 'Du har {0} ændringer i denne række og {1} skjulte kolonner',
igx_grid_toolbar_actions_filter_prompt: 'Filtrer kolonneliste ...',
igx_grid_toolbar_pinning_button_tooltip: 'Åbn rulleliste til fastgørelse af kolonner',
igx_grid_toolbar_hiding_button_tooltip: 'Åbn rulleliste til skjulning af kolonner',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsDE_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Löse alle',
igx_grid_row_edit_btn_done: 'Fertig',
igx_grid_row_edit_btn_cancel: 'Abbrechen',
igx_grid_row_edit_text: 'Sie haben {0} Änderungen in dieser Zeile und {1} ausgeblendete Spalten',
igx_grid_toolbar_actions_filter_prompt: 'Filter Spalten-Liste...',
igx_grid_toolbar_pinning_button_tooltip: 'Öffne Menü, um Spalten zu fixieren',
igx_grid_toolbar_hiding_button_tooltip: 'Öffne Menü, um Spalten zu verstecken',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsES_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Desanclar todo',
igx_grid_row_edit_btn_done: 'Listo',
igx_grid_row_edit_btn_cancel: 'Cancelar',
igx_grid_row_edit_text: 'Tienes {0} cambios en esta fila y {1} columnas ocultas',
igx_grid_toolbar_actions_filter_prompt: 'Filtrar lista de columnas…',
igx_grid_toolbar_pinning_button_tooltip: 'Abrir menú desplegable para anclar columnas',
igx_grid_toolbar_hiding_button_tooltip: 'Abrir menú desplegable para ocultar columnas',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsFR_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Détacher tout',
igx_grid_row_edit_btn_done: 'Terminé',
igx_grid_row_edit_btn_cancel: 'Annuler',
igx_grid_row_edit_text: 'Vous avez {0} modifications dans cette ligne et {1} colonnes masquées',
igx_grid_toolbar_actions_filter_prompt: 'Filtre liste des colonnes ...',
igx_grid_toolbar_pinning_button_tooltip: 'Ouvrir le menu pour attacher les colonnes',
igx_grid_toolbar_hiding_button_tooltip: 'Ouvrir le menu pour masquer les colonnes',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ const GridResourceStringsHU_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Összes rögzítésének feloldása',
igx_grid_row_edit_btn_done: 'Kész',
igx_grid_row_edit_btn_cancel: 'Mégse',
igx_grid_row_edit_text: '{0} módosítása van ebben a sorban és {1} rejtett oszlopban',
igx_grid_toolbar_actions_filter_prompt: 'Oszloplista szűrése...',
igx_grid_toolbar_pinning_button_tooltip: 'Nyissa meg az oszlop rögzítésének legördülő',
igx_grid_toolbar_hiding_button_tooltip: 'Nyissa meg az oszlop elrejtése legördülő',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsIT_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Sblocca tutto',
igx_grid_row_edit_btn_done: 'Fatto',
igx_grid_row_edit_btn_cancel: 'Annulla',
igx_grid_row_edit_text: 'Hai {0} modifiche in questa riga e {1} colonne nascoste',
igx_grid_toolbar_actions_filter_prompt: 'Filtro elenco colonne...',
igx_grid_toolbar_pinning_button_tooltip: 'Apri il menu a discesa Appuntamento colonna',
igx_grid_toolbar_hiding_button_tooltip: 'Apri il menu a discesa per nascondere la colonna',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsJA_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'すべて固定解除',
igx_grid_row_edit_btn_done: '完了',
igx_grid_row_edit_btn_cancel: 'キャンセル',
igx_grid_row_edit_text: 'この行には {0} 個の変更があり、{1} 個の非表示の列があります',
igx_grid_toolbar_actions_filter_prompt: '列リストのフィルター',
igx_grid_toolbar_pinning_button_tooltip: '列ピン固定のドロップダウンを開く',
igx_grid_toolbar_hiding_button_tooltip: '列非表示のドロップダウンを開く',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsKO_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: '모두 고정 해제',
igx_grid_row_edit_btn_done: '완료',
igx_grid_row_edit_btn_cancel: '취소',
igx_grid_row_edit_text: '이 행에는 {0}개의 변경 사항과 {1}개의 숨겨진 열이 있습니다.',
igx_grid_toolbar_actions_filter_prompt: '필터 열 목록 ...',
igx_grid_toolbar_pinning_button_tooltip: '열 고정 드롭 다운 열기',
igx_grid_toolbar_hiding_button_tooltip: '열 숨기기 드롭 다운 열기',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsNB_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Løsne alle',
igx_grid_row_edit_btn_done: 'Ferdig',
igx_grid_row_edit_btn_cancel: 'Avbryt',
igx_grid_row_edit_text: 'Du har {0} endringer i denne raden og {1} skjulte kolonner',
igx_grid_toolbar_actions_filter_prompt: 'Filtrer kolonneliste...',
igx_grid_toolbar_pinning_button_tooltip: 'Åpne rullegardinmenyen for kolonnefester',
igx_grid_toolbar_hiding_button_tooltip: 'Åpne kolonne som skjuler rullegardinmenyen',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsNL_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Alles losmaken',
igx_grid_row_edit_btn_done: 'Gereed',
igx_grid_row_edit_btn_cancel: 'Annuleren',
igx_grid_row_edit_text: 'U hebt {0} wijzigingen in deze rij en {1} verborgen kolommen',
igx_grid_toolbar_actions_filter_prompt: 'Lijst met filterkolommen ...',
igx_grid_toolbar_pinning_button_tooltip: 'Vervolgkeuzelijst kolom vastmaken openen',
igx_grid_toolbar_hiding_button_tooltip: 'Vervolgkeuzelijst kolom verbergen openen',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsPL_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Odepnij wszystko',
igx_grid_row_edit_btn_done: 'Gotowe',
igx_grid_row_edit_btn_cancel: 'Anuluj',
igx_grid_row_edit_text: 'Masz {0} zmian w tym wierszu i {1} ukrytych kolumnach',
igx_grid_toolbar_actions_filter_prompt: 'Filtruj listę kolumn...',
igx_grid_toolbar_pinning_button_tooltip: 'Otwórz menu przypinania kolumn',
igx_grid_toolbar_hiding_button_tooltip: 'Otwórz menu ukrywania kolumn',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsPT_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Desafixar tudo',
igx_grid_row_edit_btn_done: 'Concluído',
igx_grid_row_edit_btn_cancel: 'Cancelar',
igx_grid_row_edit_text: 'Tem {0} alterações nesta linha e {1} colunas ocultas',
igx_grid_toolbar_actions_filter_prompt: 'Filtrar lista de colunas...',
igx_grid_toolbar_pinning_button_tooltip: 'Abrir lista pendente de fixação de coluna',
igx_grid_toolbar_hiding_button_tooltip: 'Abrir lista pendente de ocultação de coluna',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsRO_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Anulați fixarea tuturor',
igx_grid_row_edit_btn_done: 'Terminat',
igx_grid_row_edit_btn_cancel: 'Anulați',
igx_grid_row_edit_text: 'Aveți {0} modificări în acest rând și {1} coloane ascunse',
igx_grid_toolbar_actions_filter_prompt: 'Filtrează lista coloanelor ...',
igx_grid_toolbar_pinning_button_tooltip: 'Deschideți meniul derulant de fixare a coloanei',
igx_grid_toolbar_hiding_button_tooltip: 'Deschideți meniul derulant de ascundere a coloanei',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsSV_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Lossa alla',
igx_grid_row_edit_btn_done: 'Klar',
igx_grid_row_edit_btn_cancel: 'Avbryt',
igx_grid_row_edit_text: 'Du har {0} ändringar i den här raden och {1} dolda kolumner',
igx_grid_toolbar_actions_filter_prompt: 'Filtrera kolumnlista ...',
igx_grid_toolbar_pinning_button_tooltip: 'Öppna rullgardinsmenyn med kolumnfästning',
igx_grid_toolbar_hiding_button_tooltip: 'Öppna rullgardinsmenyn som döljer kolumnen',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const GridResourceStringsTR_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: 'Tümünün Sabitlemesini Kaldır',
igx_grid_row_edit_btn_done: 'Bitti',
igx_grid_row_edit_btn_cancel: 'İptal',
igx_grid_row_edit_text: 'Bu satırda {0} değişikliğiniz ve {1} gizli sütununuz var',
igx_grid_toolbar_actions_filter_prompt: 'Sütun listesini filtrele ...',
igx_grid_toolbar_pinning_button_tooltip: 'Sütun sabitleme açılır menüsünü aç',
igx_grid_toolbar_hiding_button_tooltip: 'Sütun gizleme açılır menüsünü aç',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsZHHANS_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: '全部取消固定',
igx_grid_row_edit_btn_done: '完成',
igx_grid_row_edit_btn_cancel: '取消',
igx_grid_row_edit_text: '您在此行和 {1} 个隐藏列中有 {0} 个更改',
igx_grid_toolbar_actions_filter_prompt: '筛选列列表...',
igx_grid_toolbar_pinning_button_tooltip: '打开列固定下拉列表',
igx_grid_toolbar_hiding_button_tooltip: '打开列隐藏下拉列表',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const GridResourceStringsZHHANT_: ExpandRequire<IGridResourceStrings> = {
igx_grid_pinning_uncheck_all_label: '取消全部釘選',
igx_grid_row_edit_btn_done: '完成',
igx_grid_row_edit_btn_cancel: '取消',
igx_grid_row_edit_text: '您對此行和 {1} 個隱藏列進行了 {0} 項更改',
igx_grid_toolbar_actions_filter_prompt: '篩選條件列清單...',
igx_grid_toolbar_pinning_button_tooltip: '打開列釘選下拉式選單',
igx_grid_toolbar_hiding_button_tooltip: '打開列隱藏下拉式選單',
Expand Down
2 changes: 2 additions & 0 deletions projects/igniteui-angular/src/lib/core/i18n/grid-resources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export interface IGridResourceStrings {
igx_grid_pinning_uncheck_all_label?: string;
igx_grid_row_edit_btn_done?: string;
igx_grid_row_edit_btn_cancel?: string;
igx_grid_row_edit_text?: string;
igx_grid_toolbar_actions_filter_prompt?: string;
igx_grid_toolbar_pinning_button_tooltip?: string;
igx_grid_toolbar_hiding_button_tooltip?: string;
Expand Down Expand Up @@ -277,6 +278,7 @@ export const GridResourceStringsEN: IGridResourceStrings = {
igx_grid_pinning_uncheck_all_label: 'Unpin All',
igx_grid_row_edit_btn_done: 'Done',
igx_grid_row_edit_btn_cancel: 'Cancel',
igx_grid_row_edit_text: 'You have {0} changes in this row and {1} hidden columns',
igx_grid_toolbar_actions_filter_prompt: 'Filter columns list ...',
igx_grid_toolbar_pinning_button_tooltip: 'Open column pinning dropdown',
igx_grid_toolbar_hiding_button_tooltip: 'Open column hiding dropdown',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@
</div>

<ng-template #defaultRowEditText>
You have {{ rowChangesCount }} changes in this row and {{ hiddenColumnsCount }} hidden columns
{{ this.resourceStrings.igx_grid_row_edit_text | igxStringReplace:'{0}':rowChangesCount.toString() | igxStringReplace:'{1}':hiddenColumnsCount.toString() }}
</ng-template>

<ng-template #defaultRowEditActions>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import { IgxGridDetailsPipe } from './grid.details.pipe';
import { IgxGridSummaryPipe } from './grid.summary.pipe';
import { IgxGridGroupingPipe, IgxGridPagingPipe, IgxGridSortingPipe, IgxGridFilteringPipe } from './grid.pipes';
import { IgxSummaryDataPipe } from '../summaries/grid-root-summary.pipe';
import { IgxGridTransactionPipe, IgxHasVisibleColumnsPipe, IgxGridRowPinningPipe, IgxGridAddRowPipe, IgxGridRowClassesPipe, IgxGridRowStylesPipe } from '../common/pipes';
import { IgxGridTransactionPipe, IgxHasVisibleColumnsPipe, IgxGridRowPinningPipe, IgxGridAddRowPipe, IgxGridRowClassesPipe, IgxGridRowStylesPipe, IgxStringReplacePipe } from '../common/pipes';
import { IgxGridColumnResizerComponent } from '../resizing/resizer.component';
import { IgxRowEditTabStopDirective } from '../grid.rowEdit.directive';
import { IgxIconComponent } from '../../icon/icon.component';
Expand Down Expand Up @@ -153,8 +153,9 @@ export interface IGroupingDoneEventArgs extends IBaseEventArgs {
IgxGridSortingPipe,
IgxGridFilteringPipe,
IgxGridSummaryPipe,
IgxGridDetailsPipe
],
IgxGridDetailsPipe,
IgxStringReplacePipe
],
schemas: [CUSTOM_ELEMENTS_SCHEMA]
})
export class IgxGridComponent extends IgxGridBaseDirective implements GridType, OnInit, DoCheck, AfterContentInit, AfterViewInit {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
</div>
</div>
<ng-template #defaultRowEditText>
You have {{ rowChangesCount }} changes in this row and {{ hiddenColumnsCount }} hidden columns
{{ this.resourceStrings.igx_grid_row_edit_text | igxStringReplace:'{0}':rowChangesCount.toString() | igxStringReplace:'{1}':hiddenColumnsCount.toString() }}
</ng-template>
<ng-template #defaultRowEditActions>
<button type="button" igxButton igxRowEditTabStop (click)="this.endRowEditTabStop(false, $event)">{{ this.resourceStrings.igx_grid_row_edit_btn_cancel }}</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import { IgxGridExcelStyleFilteringComponent } from '../filtering/excel-style/ex
import { IgxGridValidationService } from '../grid/grid-validation.service';
import { IgxGridHierarchicalPipe, IgxGridHierarchicalPagingPipe } from './hierarchical-grid.pipes';
import { IgxSummaryDataPipe } from '../summaries/grid-root-summary.pipe';
import { IgxGridTransactionPipe, IgxHasVisibleColumnsPipe, IgxGridRowPinningPipe, IgxGridAddRowPipe, IgxGridRowClassesPipe, IgxGridRowStylesPipe } from '../common/pipes';
import { IgxGridTransactionPipe, IgxHasVisibleColumnsPipe, IgxGridRowPinningPipe, IgxGridAddRowPipe, IgxGridRowClassesPipe, IgxGridRowStylesPipe, IgxStringReplacePipe } from '../common/pipes';
import { IgxGridSortingPipe, IgxGridFilteringPipe } from '../grid/grid.pipes';
import { IgxGridColumnResizerComponent } from '../resizing/resizer.component';
import { IgxRowEditTabStopDirective } from '../grid.rowEdit.directive';
Expand Down Expand Up @@ -349,8 +349,9 @@ export class IgxChildGridRowComponent implements AfterViewInit, OnInit {
IgxGridRowStylesPipe,
IgxSummaryDataPipe,
IgxGridHierarchicalPipe,
IgxGridHierarchicalPagingPipe
],
IgxGridHierarchicalPagingPipe,
IgxStringReplacePipe
],
schemas: [CUSTOM_ELEMENTS_SCHEMA]
})
export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirective
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
</div>

<ng-template #defaultRowEditText>
You have {{ rowChangesCount }} changes in this row and {{ hiddenColumnsCount }} hidden columns
{{ this.resourceStrings.igx_grid_row_edit_text | igxStringReplace:'{0}':rowChangesCount.toString() | igxStringReplace:'{1}':hiddenColumnsCount.toString() }}
</ng-template>

<ng-template #defaultRowEditActions>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ import { IgxTreeGridSummaryPipe } from './tree-grid.summary.pipe';
import { IgxTreeGridFilteringPipe } from './tree-grid.filtering.pipe';
import { IgxTreeGridHierarchizingPipe, IgxTreeGridFlatteningPipe, IgxTreeGridSortingPipe, IgxTreeGridPagingPipe, IgxTreeGridTransactionPipe, IgxTreeGridNormalizeRecordsPipe, IgxTreeGridAddRowPipe } from './tree-grid.pipes';
import { IgxSummaryDataPipe } from '../summaries/grid-root-summary.pipe';
import { IgxHasVisibleColumnsPipe, IgxGridRowPinningPipe, IgxGridRowClassesPipe, IgxGridRowStylesPipe } from '../common/pipes';
import { IgxHasVisibleColumnsPipe, IgxGridRowPinningPipe, IgxGridRowClassesPipe, IgxGridRowStylesPipe, IgxStringReplacePipe } from '../common/pipes';
import { IgxGridColumnResizerComponent } from '../resizing/resizer.component';
import { IgxIconComponent } from '../../icon/icon.component';
import { IgxRowEditTabStopDirective } from '../grid.rowEdit.directive';
Expand Down Expand Up @@ -169,8 +169,9 @@ let NEXT_ID = 0;
IgxTreeGridTransactionPipe,
IgxTreeGridSummaryPipe,
IgxTreeGridNormalizeRecordsPipe,
IgxTreeGridAddRowPipe
],
IgxTreeGridAddRowPipe,
IgxStringReplacePipe
],
schemas: [CUSTOM_ELEMENTS_SCHEMA]
})
export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridType, OnInit, AfterViewInit, DoCheck, AfterContentInit {
Expand Down

0 comments on commit 9792b4d

Please sign in to comment.