Skip to content

Commit

Permalink
refactor(themes): use already ingested border-radius (#13483)
Browse files Browse the repository at this point in the history
---------

Co-authored-by: Silvia Ivanova <[email protected]>
  • Loading branch information
simeonoff and SisIvanova authored Sep 27, 2023
1 parent 08b1664 commit 82b740a
Show file tree
Hide file tree
Showing 28 changed files with 17 additions and 121 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@types/source-map": "0.5.2",
"fflate": "^0.7.3",
"hammerjs": "^2.0.8",
"igniteui-theming": "^3.0.6",
"igniteui-theming": "^3.1.0",
"igniteui-trial-watermark": "^2.0.0",
"lodash-es": "^4.17.21",
"rxjs": "^6.6.7",
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"igniteui-trial-watermark": "^1.0.3",
"lodash-es": "^4.17.21",
"uuid": "^9.0.0",
"igniteui-theming": "^3.0.6",
"igniteui-theming": "^3.1.0",
"@igniteui/material-icons-extended": "^3.0.0"
},
"peerDependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
}

@if not($actions-border-radius) {
$actions-border-radius: border-radius(map.get($theme, 'actions-border-radius')...);
$actions-border-radius: map.get($theme, 'actions-border-radius');
}

@return extend($theme, (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@
$shadow: elevation($elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
selector: $selector,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,6 @@
$_active-shadow: elevation($active-elevation);
}

@if not($_border-radius) {
$_border-radius: border-radius(map.get($_schema, 'border-radius')...);
}

$themes: map.merge($themes, (
$_name: extend( digest-schema($_schema), (
name: $name,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,18 +323,6 @@
$week-number-color: text-contrast($week-number-background);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@if not($month-border-radius) {
$month-border-radius: border-radius(map.get($theme, 'month-border-radius')...);
}

@if not($date-border-radius) {
$date-border-radius: border-radius(map.get($theme, 'date-border-radius')...);
}

@return extend($theme, (
name: $name,
selector: $selector,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@
$hover-shadow: elevation($hover-elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
background: $background,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@
}
}

@if not($border-radius){
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,6 @@
$theme: digest-schema($checkbox-schema);
$meta: map.get($theme, '_meta');

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@if not($border-radius-ripple) {
$border-radius-ripple: border-radius(map.get($theme, 'border-radius-ripple')...);
}

@return extend($theme, (
name: $name,
label-color: $label-color,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,6 @@
$ghost-shadow: elevation($ghost-elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
selector: $selector,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@
$shadow: elevation($elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
selector: $selector,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,6 @@
$shadow: elevation($elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@if not($item-border-radius) {
$item-border-radius: border-radius(map.get($theme, 'item-border-radius')...);
}

@return extend($theme, (
name: $name,
selector: $selector,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@
$body-color: text-contrast($body-background);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
header-background: $header-background,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@
}

@if not($drop-area-border-radius) {
$drop-area-border-radius: border-radius(map.get($theme, 'drop-area-border-radius')...);
$drop-area-border-radius: map.get($theme, 'drop-area-border-radius');
}

@return extend($theme, (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,15 @@
}

@if not($box-border-radius) {
$box-border-radius: border-radius(map.get($theme, 'box-border-radius')...);
$box-border-radius: map.get($theme, 'box-border-radius');
}

@if not($border-border-radius) {
$border-border-radius: border-radius(map.get($theme, 'border-border-radius')...);
$border-border-radius: map.get($theme, 'border-border-radius');
}

@if not($search-border-radius) {
$search-border-radius: border-radius(map.get($theme, 'search-border-radius')...);
$search-border-radius: map.get($theme, 'search-border-radius');
}

@return extend($theme, (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,6 @@
$item-subtitle-color-active: $item-text-color-active;
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@if not($item-border-radius) {
$item-border-radius: border-radius(map.get($theme, 'item-border-radius')...);
}

@return extend($theme, (
name: $name,
border-radius: $border-radius,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,6 @@
$shadow: elevation($elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@if not($item-border-radius) {
$item-border-radius: border-radius(map.get($theme, 'item-border-radius')...);
}

@return extend($theme, (
name: $name,
border-radius: $border-radius,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
$meta: map.get($theme, '_meta');

@if not($track-border-radius) {
$track-border-radius: border-radius(map.get($theme, 'track-border-radius')...);
$track-border-radius: map.get($theme, 'track-border-radius');
}

@return extend($theme, (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@
$shadow: elevation($elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
border-radius: $border-radius,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@
$expander-color: text-contrast($bar-color);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
bar-color: $bar-color,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,11 @@
}

@if not($border-radius-indicator) {
$border-radius-indicator: border-radius(map.get($theme, 'border-radius-indicator')...);
$border-radius-indicator: map.get($theme, 'border-radius-indicator');
}

@if not($border-radius-step-header) {
$border-radius-step-header: border-radius(map.get($theme, 'border-radius-step-header')...);
$border-radius-step-header: map.get($theme, 'border-radius-step-header');
}

@return extend($theme, (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,15 @@
}

@if not($border-radius-track) {
$border-radius-track: border-radius(map.get($theme, 'border-radius-track')...);
$border-radius-track: map.get($theme, 'border-radius-track');
}

@if not($border-radius-thumb) {
$border-radius-thumb: border-radius(map.get($theme, 'border-radius-thumb')...);
$border-radius-thumb: map.get($theme, 'border-radius-thumb');
}

@if not($border-radius-ripple) {
$border-radius-ripple: border-radius(map.get($theme, 'border-radius-ripple')...);
$border-radius-ripple: map.get($theme, 'border-radius-ripple');
}

@return extend($theme, (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,6 @@
$tab-ripple-color: text-contrast($item-background);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
item-text-color: $item-text-color,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,6 @@
$dropdown-shadow: elevation($elevation);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@if not($active-item-border-radius) {
$active-item-border-radius: border-radius(map.get($theme, 'active-item-border-radius')...);
}

@return extend($theme, (
name: $name,
selector: $selector,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@
$text-color: text-contrast($background);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
background: $background,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
$text-color: text-contrast($background);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
selector: $selector,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@
$color: text-contrast($link-background);
}

@if not($border-radius) {
$border-radius: border-radius(map.get($theme, 'border-radius')...);
}

@return extend($theme, (
name: $name,
selector: 'igc-trial-watermark',
Expand Down

0 comments on commit 82b740a

Please sign in to comment.