php: Split phpstan tests into a separate workflow (#220)

Icinga · Apr 9, 2024 · 9ac6b63 · 9ac6b63
2 parents de9f622 + 0128d2a
commit 9ac6b63
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 13 deletions.
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -17,12 +17,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
+        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
         os: ['ubuntu-latest']
 
     steps:
       - name: Checkout code base
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
@@ -31,11 +31,7 @@ jobs:
           tools: phpcs
 
       - name: Setup dependencies
-        run: |
-          composer require -n --no-progress overtrue/phplint phpstan/phpstan
-          sudo git clone --depth 1 https://github.com/Icinga/icingaweb2.git /icingaweb2
-          sudo git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-library.git /usr/share/icinga-php/ipl
-          sudo git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-thirdparty.git /usr/share/icinga-php/vendor
+        run: composer require -n --no-progress overtrue/phplint
 
       - name: PHP Lint
         if: ${{ ! cancelled() }}
@@ -45,10 +41,6 @@ jobs:
         if: ${{ ! cancelled() }}
         run: phpcs -wps --colors
 
-      - name: PHPStan
-        if: ${{ ! cancelled() }}
-        run: ./vendor/bin/phpstan analyse
-
   test:
     name: Unit tests with php ${{ matrix.php }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
@@ -59,12 +51,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
+        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
         os: ['ubuntu-latest']
 
     steps:
       - name: Checkout code base
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2

diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml
@@ -0,0 +1,15 @@
+name: PHPStan
+
+on:
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  phpstan:
+    uses: icinga/github-actions/.github/workflows/phpstan.yml@main
+    with:
+      dependencies: |
+        {
+          "/icingaweb2": "https://github.com/Icinga/icingaweb2.git"
+        }