-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source configuration UI #156
Conversation
f56d03a
to
e371696
Compare
FYI, @julianbrost's comment regarding a custom certificate Common Name was now implemented in Icinga/icinga-notifications#112's commit Icinga/icinga-notifications@24a4843. |
77ff2ce
to
89a7fcc
Compare
0993d47
to
fddd4f0
Compare
@oxzi A functional review and whether the options are correctly managed/stored is sufficient 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have tested this with the current HEAD
of Icinga/icinga-notifications#112 running as the backend.
I have successfully altered my existing source entry and also created a new one from scratch.
However, I realized that it is impossible to remove a source once an object was created linked to it, but this might be another day's issue:
SQLSTATE[23503]: Foreign key violation: 7 ERROR: update or delete on table "source" violates foreign key constraint "object_source_id_fkey" on table "object" DETAIL: Key (id)=(1) is still referenced from table "object".
fddd4f0
to
b6ecb03
Compare
Yep. That's not only a problem here. Any other configuration is affected by this as well. |
9f4bacc
to
d57ee1d
Compare
d57ee1d
to
40f11ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested the changes in the web and got the expected behavior from the icinga-notifications daemon.
resolves #147
requires Icinga/ipl-web#214