Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source configuration UI #156

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Add source configuration UI #156

merged 2 commits into from
Apr 15, 2024

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jan 16, 2024

resolves #147

requires Icinga/ipl-web#214

@nilmerg nilmerg added the enhancement New feature or improvement label Jan 16, 2024
@nilmerg nilmerg added this to the Preview #1 milestone Jan 16, 2024
@nilmerg nilmerg self-assigned this Jan 16, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jan 16, 2024
@oxzi
Copy link
Member

oxzi commented Jan 17, 2024

@nilmerg nilmerg force-pushed the add-source-config-ui branch 2 times, most recently from 77ff2ce to 89a7fcc Compare January 17, 2024 14:23
@nilmerg nilmerg marked this pull request as ready for review January 17, 2024 14:24
@nilmerg nilmerg requested a review from oxzi January 17, 2024 14:24
@nilmerg nilmerg force-pushed the add-source-config-ui branch 2 times, most recently from 0993d47 to fddd4f0 Compare January 17, 2024 14:47
@nilmerg
Copy link
Member Author

nilmerg commented Jan 17, 2024

@oxzi A functional review and whether the options are correctly managed/stored is sufficient 😉

Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have tested this with the current HEAD of Icinga/icinga-notifications#112 running as the backend.

I have successfully altered my existing source entry and also created a new one from scratch.

However, I realized that it is impossible to remove a source once an object was created linked to it, but this might be another day's issue:

SQLSTATE[23503]: Foreign key violation: 7 ERROR: update or delete on table "source" violates foreign key constraint "object_source_id_fkey" on table "object" DETAIL: Key (id)=(1) is still referenced from table "object".

application/forms/SourceForm.php Outdated Show resolved Hide resolved
application/forms/SourceForm.php Show resolved Hide resolved
application/forms/SourceForm.php Outdated Show resolved Hide resolved
@nilmerg
Copy link
Member Author

nilmerg commented Jan 19, 2024

However, I realized that it is impossible to remove a source once an object was created linked to it, but this might be another day's issue:

Yep. That's not only a problem here. Any other configuration is affected by this as well.

Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested the changes in the web and got the expected behavior from the icinga-notifications daemon.

@nilmerg nilmerg merged commit a879c50 into main Apr 15, 2024
22 checks passed
@nilmerg nilmerg deleted the add-source-config-ui branch April 15, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config forms for source table
2 participants