Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Frontend] Keep View Mode in localStorage #6463

Merged
merged 22 commits into from
Sep 30, 2024
Merged

✨ [Frontend] Keep View Mode in localStorage #6463

merged 22 commits into from
Sep 30, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 27, 2024 •
edited
Loading

What do these changes do?

  • Remember user's view mode (list, grid) selection by keeping it in the localStorage
  • Improve the list item's UI
    • Smaller
    • Remove description
    • Center read only permission
    • Bind width to container's width
    • If it's too small, hide tags, owner and TSR

ViewMode

Related issue/s

related to ITISFoundation/osparc-issues#1728

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 27, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 27, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 27, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 30, 2024 09:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz enabled auto-merge (squash) September 30, 2024 09:53
GitHK
GitHK reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jsaq007
jsaq007 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 I haven't built locally

@odeimaiz odeimaiz merged commit 0ed6d0a into ITISFoundation:master Sep 30, 2024
50 of 51 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@odeimaiz
✨ [Frontend] Keep View Mode in localStorage (ITISFoundation#6463)
c0ba01a
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK left review comments

@jsaq007 jsaq007 jsaq007 approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@pcrespov pcrespov Awaiting requested review from pcrespov

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @jsaq007 @GitHK @matusdrobuliak66