Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 make folders optional + improvements ⚠️ #6155

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 8, 2024

What do these changes do?

  • 🎨 folders improvements
    • pass variable to frontend -> for enable/disable folders plugin
    • in the folders listing, support folder_id = "null" or "none"
    • improve pagination model on the folders listing (include total count metadata)
    • add default sorting on folders listing (modified_at)
    • add sorting query to folders query (name, description)
    • On folder create, return the whole Folder object (including the access rights, owner)
    • Add folder get endpoint
    • in the project listing, support folder_id = "null" or "none"
    • Filter folders by product

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 8, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Tom Bombadil milestone Aug 8, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 8, 2024 10:43
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.1%. Comparing base (cafbf96) to head (98a81ab).
Report is 434 commits behind head on master.

Files Patch % Lines
...ore_service_webserver/folders/_folders_handlers.py 85.7% 2 Missing ⚠️
...re_service_webserver/projects/_folders_handlers.py 83.3% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6155      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1349    +1339     
  Lines         214   58150   +57936     
  Branches       25    1250    +1225     
=========================================
+ Hits          181   51249   +51068     
- Misses         23    6633    +6610     
- Partials       10     268     +258     
Flag Coverage Δ
integrationtests 64.8% <32.5%> (?)
unittests 85.9% <94.4%> (+1.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/models_library/api_schemas_webserver/folders.py 100.0% <100.0%> (ø)
...rary/src/models_library/utils/common_validators.py 76.4% <100.0%> (ø)
...re_service_webserver/application_settings_utils.py 98.0% <ø> (ø)
.../simcore_service_webserver/folders/_folders_api.py 100.0% <100.0%> (ø)
...mcore_service_webserver/projects/_crud_api_read.py 96.6% <100.0%> (ø)
...ervice_webserver/projects/_crud_handlers_models.py 98.1% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 97.4% <100.0%> (ø)
...re_service_webserver/projects/_folders_handlers.py 93.7% <83.3%> (ø)
...ore_service_webserver/folders/_folders_handlers.py 93.0% <85.7%> (ø)

... and 1301 files with indirect coverage changes

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok consider my comments. thanks

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Left some suggestions

@matusdrobuliak66 matusdrobuliak66 modified the milestones: Tom Bombadil, Eisbock Aug 14, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 make folders optional 🎨 make folders optional + improvements Aug 14, 2024
@odeimaiz odeimaiz self-requested a review August 14, 2024 06:22
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you very much

@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 make folders optional + improvements 🎨 make folders optional + improvements ⚠️ Aug 14, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!thx!

Copy link

sonarcloud bot commented Aug 14, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit c1da03c into ITISFoundation:master Aug 14, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the enable-disable-folders branch August 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web API: /folders CRUD operations
6 participants